prctl instead of pthread on linux for name setup #23640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| let cname = CString::new(name).unwrap_or_else(|_| { | ||
| panic!("thread name may not contain interior null bytes") | ||
| }); | ||
| assert!(prctl(PR_SET_NAME, cname.as_ptr() as libc::c_ulong, 0, 0, 0) == 0); |
There was a problem hiding this comment.
Won't this call return a failure on kernels which don't suppot PR_SET_NAME? I'd also be fine just ignoring the return value, if this fails it's not really the end of the world!
There was a problem hiding this comment.
I’m ambivalent about this. Updated.
This is more portable as far as linux is concerned.
nagisa
force-pushed
the
thread-less-weak
branch
from
dcef9d2 to
d29d554
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
This is more portable as far as linux is concerned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more portable as far as linux is concerned.