unignore lexer tests #23209
unignore lexer tests #23209
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I'm not sure if this is a good time to be making sweeping changes like this... (to elaborate: I would prefer to delay largely aesthetic developer changes like this to at least after the 1.0 beta release, if not until after 1.0 itself. But perhaps I am over-estimating the amount of impedance changes like this can introduce to the code base, and/or under-estimating how well git can compensate for them.) |
|
Sure. I'm fairly indifferent about the last commit (it bothered me enough to change it, but not enough that I'm never going to run the tests again if it doesn't land). The first two commits should go in regardless though. |
|
I would also prefer to avoid changes like this for now, the first two commits are fine by me though! |
richo
force-pushed
the
normalize-test-names
branch
from
afc69c4 to
58a288d
Compare
|
⌛ Testing commit 58a288d with merge d045d0f... |
…richton Motivated by the test output not lining up when it could, I normalized all of the issue-* tests. While doing it, I found some lexer tests that could be unignored and fixed an int -> isize.
|
⛄ The build was interrupted to prioritize another pull request. |
Motivated by the test output not lining up when it could, I normalized all of the issue-* tests. While doing it, I found some lexer tests that could be unignored and fixed an int -> isize.
Motivated by the test output not lining up when it could, I normalized all of the issue-* tests.
While doing it, I found some lexer tests that could be unignored and fixed an int -> isize.