Rollup of PRs in the queue; Saturday #22895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of `rustc --version` was changed in rust-lang#21957.
MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return. Fixes rust-lang#17637. Based on rust-lang#18814. This is a [breaking-change] for syntax extensions: * MacExpr::new becomes MacEager::expr. * MacPat::new becomes MacEager::pat. * MacItems::new becomes MacEager::items. It takes a SmallVector directly, not an iterator.
Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:
* `{set,get}_exit_status` - there are still questions about whether this is the
right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.
This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
Signed-off-by: JP-Ellis <coujellis@gmail.com>
Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:
* `{set,get}_exit_status` - there are still questions about whether this is the
right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.
This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return. Fixes rust-lang#17637. Based on rust-lang#18814. This is a [breaking-change] for syntax extensions: * MacExpr::new becomes MacEager::expr. * MacPat::new becomes MacEager::pat. * MacItems::new becomes MacEager::items. It takes a SmallVector directly, not an iterator. r? @sfackler
This is leftover from rust-lang#21843 If you still have `|&:| {}` closures in your code, simply remove the `&:` part. [breaking-change]
…anishearth The format of `rustc --version` was changed in rust-lang#21957; this PR updates TRPL accordingly.
Updated the function to allow comparisons between different types since PartialOrd and PartialEq allow this.
|
@bors: p=20 r+ |
|
@bors: force |
bors
added a commit
that referenced
this pull request
Feb 28, 2015
This was referenced Feb 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth