test: Use Thread::scoped in two more tests #20925
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw these hanging on a windows bot, and the previous ones seem to have calmed down after switching from Thread::spawn to Thread::scoped, so try that here as well!
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
Is the theory that bad things happen if the main thread exits before other threads? |
Member
Author
|
Yeah I'm not quite sure what's going on here, but all the tests which hang indefinitely all have some thread which may live past the main thread exiting. Many of them are also related to failure in child threads, but I'm not sure if all of them are. cc #20704, the previous set of tests |
bors
added a commit
that referenced
this pull request
Jan 11, 2015
I saw these hanging on a windows bot, and the previous ones seem to have calmed down after switching from Thread::spawn to Thread::scoped, so try that here as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw these hanging on a windows bot, and the previous ones seem to have calmed
down after switching from Thread::spawn to Thread::scoped, so try that here as
well!