Skip to content

Refactor upvar mode inference #20432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 3, 2015
Merged

Refactor upvar mode inference #20432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7abf47
Re-introduce `McResult<>` as a way of aborting mem-categorization (and
nikomatsakis Jan 2, 2015
9c54d86
Stop calling `bug()` in various weird cases and instead generate `Err…
nikomatsakis Jan 2, 2015
429d9cc
Be more tolerant of errors in EUV so we can run it during typeck.
nikomatsakis Jan 2, 2015
83ef304
Modify `type_known_to_meet_builtin_bound` so that it doesn't suppress…
nikomatsakis Jan 2, 2015
7474be0
Make `ty::ParameterEnvironment`, not `ty::ctxt`, implement `Typer` and
nikomatsakis Jan 2, 2015
ecd9c10
Move upvar checking into its own pre-pass that occurs before regionck
nikomatsakis Jan 2, 2015
09a7bc5
Running EUV requires the Copy lang item, so adjust privacy tests.
nikomatsakis Jan 2, 2015
cbeff8b
"Fallout": Slightly different errors are generated in this edge case.
nikomatsakis Jan 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Running EUV requires the Copy lang item, so adjust privacy tests.
  • Loading branch information
@nikomatsakis
nikomatsakis committed Jan 3, 2015
commit 09a7bc55dbd2bd4e05253b2bd72e5ecfb5cf7dd2
3 changes: 3 additions & 0 deletions src/test/compile-fail/privacy1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
#[lang="sized"]
pub trait Sized {}

#[lang="copy"]
pub trait Copy {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way the compiler could pretend to have Sized or Copy?
Not that I wouldn't use libcore for this, but sometimes libcore doesn't compile and I need a testcase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice, but it's a big pain to propagate that pretending everywhere.


mod bar {
// shouldn't bring in too much
pub use self::glob::*;
Expand Down
1 change: 1 addition & 0 deletions src/test/compile-fail/privacy4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#![no_std] // makes debugging this test *a lot* easier (during resolve)

#[lang = "sized"] pub trait Sized for Sized? {}
#[lang="copy"] pub trait Copy {}

// Test to make sure that private items imported through globs remain private
// when they're used.
Expand Down