Add doctests for keys() and values() of the BTreeMap collection. #19555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro |
| /// a.insert(2u, "b"); | ||
| /// | ||
| /// let keys: Vec<uint> = a.keys().map(|&x| x).collect(); | ||
| /// assert_eq!(keys, [1u,2].iter().map(|&x| x).collect()); |
There was a problem hiding this comment.
for making keys, I would do a.keys().cloned().collect(). For the vec you use for comparison, I would use vec![1, 2].
There was a problem hiding this comment.
I'll make the suggested changes 😸
|
@gankro how does it look now? It looks a lot cleaner to me ✨ |
|
Looks great! r=me with squashed commits. |
Update keys() and values() for BTreeMap based on @gankro's comments. Assign keys and values to variables before doing assertion.
jbranchaud
force-pushed
the
add-doctests-for-key-values-of-btreemap
branch
from
62ee5d9 to
d6b6df0
Compare
|
squashed! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.