Skip to content

Implement BitXor for EnumSet. #18756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2014
Merged

Conversation

jbcrail
Copy link
Contributor

@jbcrail jbcrail commented Nov 7, 2014

I implemented BitXor, and also added tests for BitAnd and BitXor.

cc #18424

@@ -196,6 +195,12 @@ impl<E:CLike> BitAnd<EnumSet<E>, EnumSet<E>> for EnumSet<E> {
}
}

impl<E:CLike> BitXor<EnumSet<E>, EnumSet<E>> for EnumSet<E> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an unstable marker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or... Wait... Trait impl... Uh...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah nvm

@Gankra
Copy link
Contributor

Gankra commented Nov 8, 2014

LGTM

bors added a commit that referenced this pull request Nov 9, 2014
I implemented BitXor, and also added tests for BitAnd and BitXor.

cc #18424
@bors bors closed this Nov 9, 2014
@bors bors merged commit 12db4de into rust-lang:master Nov 9, 2014
@Gankra
Copy link
Contributor

Gankra commented Nov 9, 2014

Thanks, @jbcrail!

@jbcrail jbcrail deleted the add-enum-set-bitxor branch November 9, 2014 18:30
lnicola pushed a commit to lnicola/rust that referenced this pull request Jan 7, 2025
fix missing name enum when hovering on fields in variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants