Convert some notes to help messages #18132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,6 @@ fn main() { | |||
| .map(|x| x) | |||
| .filter(|&&x| x == 1) | |||
| .filter_map; //~ ERROR attempted to take value of method `filter_map` on type | |||
| //~^ NOTE maybe a missing `()` to call it? If not, try an anonymous function. | |||
| //~^ HELP maybe a `()` to call it is missing | |||
There was a problem hiding this comment.
Does the compiletest driver actually support these?
There was a problem hiding this comment.
Yes, it generically supports any kind of message; I could add a new type of message, foo, to the compiler, and it would automatically support them. There are plenty of tests which use NOTE, and yet there are no mentions of the word note in src/compiletest other than a few debug print messages.
(Plus, I tested it with an invalid message.)
ftxqxd
force-pushed
the
more-help
branch
2 times, most recently
from
54f5754 to
a69c6a0
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 4, 2014
bors
added a commit
that referenced
this pull request
Nov 4, 2014
Closes #18126. At the moment this mostly only changes notes that are particularly help-oriented or directly suggest the user to do something to help messages, and does not change messages that simply explain an error message further. If it is decided that those messages should also be help messages, I can add them to this PR, but for now I’m excluding them as I believe that changing those messages might leave very few places where notes would be appropriate.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
…eykril fix: Don't complete `;` when in closure return expression Completing it will break syntax. Fixes rust-lang#18130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18126.
At the moment this mostly only changes notes that are particularly help-oriented or directly suggest the user to do something to help messages, and does not change messages that simply explain an error message further. If it is decided that those messages should also be help messages, I can add them to this PR, but for now I’m excluding them as I believe that changing those messages might leave very few places where notes would be appropriate.