Two Windows fixes #16691
Merged
Two Windows fixes #16691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MSYS shell executes program, if its arguments look like MSYS paths, MSYS automatically converts them into Windows paths. For example, `/c/path:/d/path` becomes `C:\path;D:\path`. However, if there is only one path e.g. `/c/path`, it becomes `C:/path`. maketest.py reverts the behavior to reduce confusion between MSYS and Windows, but it didn't handle the `/c/path` case. This patch fixes the issue. Fixes rust-lang#15297 Fixes rust-lang#15250
|
Does this mean that users of mingw-w64 will get a 64-bit build by default? We don't currently have automation set up just yet (coming soon!), so I just want to clarify. |
|
I think it will depend on whether you start msys2 with the mingw32 shell or the mingw64 shell. I'm not sure about non-msys2 environments, but msys2 is the sanest way to use Rust on Windows. |
|
@alexcrichton mingw-w64/32-bit user will get 32-bit build. |
bors
added a commit
that referenced
this pull request
Aug 23, 2014
First commit fixes issue regarding recognizing MSYS2 build. Second commit fixes issue regarding MSYS/Windows paths.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
…Veykril fix: Fix completions panicking with certain macro setups Unable to figure out a test case for this but managed to run into it in r-a reproducably. Fixes rust-lang/rust-analyzer#16266 Fixes rust-lang/rust-analyzer#13255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes issue regarding recognizing MSYS2 build.
Second commit fixes issue regarding MSYS/Windows paths.