Skip to content

stdarch: Mark the loongarch modules stable - #164133

Open
tgross35 wants to merge 1 commit into
rust-lang:mainfrom
tgross35:stdarch-loongarch-mod
Open

tgross35 wants to merge 1 commit into
rust-lang:mainfrom
tgross35:stdarch-loongarch-mod

Conversation

@tgross35

Copy link
Copy Markdown
Member

Some loongarch intrinsics were marked stable in rust-lang/stdarch#2137 but the modules never were, so the intrinsics cannot be used stably https://rust.godbolt.org/z/TMcor67a4.

cc @heiher

@rustbot

rustbot commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 11, 2026
@rustbot

rustbot commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey

#[cfg(any(target_arch = "loongarch32", doc))]
#[doc(cfg(target_arch = "loongarch32"))]
#[unstable(feature = "stdarch_loongarch", issue = "117427")]
#[stable(feature = "stdarch_loongarch_mod", since = "CURRENT_RUSTC_VERSION")]

@heiher heiher Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are no LoongArch32 intrinsics that have been stabilized yet.

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the same thing. Dropped it from this PR

Some loongarch intrinsics were marked stable but the modules never were,
so the intrinsics cannot be used stably <https://rust.godbolt.org/z/TMcor67a4>.
@tgross35
tgross35 force-pushed the stdarch-loongarch-mod branch from 980cf2e to e37a5a2 Compare October 11, 2026 04:11

@heiher heiher left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants