Repository navigation
Better debug impls for some assumptions on binders types - #163939
Merged
rust-bors[bot] merged 1 commit intoOct 9, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
Member
|
lgtm, needs a bless though, r=me when blessed (probably will super merge conflict with the other abby dsl prs today tho...) |
khyperia
added
S-waiting-on-author
BoxyUwU
force-pushed
the
abby_slight_debug_impl_improvements
branch
from
October 9, 2026 12:33
69dfb07 to
07d67c6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=khyperia |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 9, 2026
…rovements, r=khyperia Better debug impls for some assumptions on binders types r? @khyperia Debug output for abby stuff was really annoying to read :> All of the assumptions had a tonne of unreadable stuff about the region graph rather than a nice output. I'm not entirely sure what to do here. I just omit the information now which uh feels kinda dubious but also having *both* of the relations is *so* noisy especially with their current representation where its just a list of nodes and edges where it's super hard to read 😅 Also made `LeafRegionConstraint` not spit out a tonne of span information polluting the entire everything when looking at region constraints 😅
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 9, 2026
…rovements, r=khyperia Better debug impls for some assumptions on binders types r? @khyperia Debug output for abby stuff was really annoying to read :> All of the assumptions had a tonne of unreadable stuff about the region graph rather than a nice output. I'm not entirely sure what to do here. I just omit the information now which uh feels kinda dubious but also having *both* of the relations is *so* noisy especially with their current representation where its just a list of nodes and edges where it's super hard to read 😅 Also made `LeafRegionConstraint` not spit out a tonne of span information polluting the entire everything when looking at region constraints 😅
This was referenced Oct 9, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
…uwer Rollup of 24 pull requests Successful merges: - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - #162106 (Helpful suggestions for incorrect address-of mutability (2)) - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - #163939 (Better debug impls for some assumptions on binders types) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #164042 (Allow testing cg-gcc on any target) - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - #162908 (Fix - const parameters rejected when identical) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164008 (properly ignore the current goal's usages) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
Rollup merge of #163939 - BoxyUwU:abby_slight_debug_impl_improvements, r=khyperia Better debug impls for some assumptions on binders types r? @khyperia Debug output for abby stuff was really annoying to read :> All of the assumptions had a tonne of unreadable stuff about the region graph rather than a nice output. I'm not entirely sure what to do here. I just omit the information now which uh feels kinda dubious but also having *both* of the relations is *so* noisy especially with their current representation where its just a list of nodes and edges where it's super hard to read 😅 Also made `LeafRegionConstraint` not spit out a tonne of span information polluting the entire everything when looking at region constraints 😅
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Oct 12, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - rust-lang/rust#162106 (Helpful suggestions for incorrect address-of mutability (2)) - rust-lang/rust#162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - rust-lang/rust#163337 (MIR move elimination [3/6]: PreciseLiveness) - rust-lang/rust#163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - rust-lang/rust#163939 (Better debug impls for some assumptions on binders types) - rust-lang/rust#163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - rust-lang/rust#163956 (Pass the unremapped path to the `rustc` invocation for doctests) - rust-lang/rust#164042 (Allow testing cg-gcc on any target) - rust-lang/rust#162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - rust-lang/rust#162908 (Fix - const parameters rejected when identical) - rust-lang/rust#163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - rust-lang/rust#163634 (move overflow lint computation into decorator) - rust-lang/rust#163666 (Updates the expect message library/core/src/time.rs) - rust-lang/rust#163727 (rigid aliases to non-rigid for fully normalized check) - rust-lang/rust#163745 (replace `fully_monomorphized` with `cx.typing_env()`) - rust-lang/rust#163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - rust-lang/rust#163950 (don't treat inherited opaques as defining) - rust-lang/rust#163972 (const-eval: ICE when we hit a non-const fn) - rust-lang/rust#164000 (When mentioning that closure doesn't implement trait, point at closure) - rust-lang/rust#164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - rust-lang/rust#164008 (properly ignore the current goal's usages) - rust-lang/rust#164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - rust-lang/rust#164025 (Less `CanonicalVarValues`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @khyperia
Debug output for abby stuff was really annoying to read :> All of the assumptions had a tonne of unreadable stuff about the region graph rather than a nice output. I'm not entirely sure what to do here. I just omit the information now which uh feels kinda dubious but also having both of the relations is so noisy especially with their current representation where its just a list of nodes and edges where it's super hard to read 😅
Also made
LeafRegionConstraintnot spit out a tonne of span information polluting the entire everything when looking at region constraints 😅