Skip to content

Remove TypeChecker::root_cx - #163082

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nnethercote:rm-TypeChecker-root_cx
Sep 21, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nnethercote:rm-TypeChecker-root_cx

Conversation

@nnethercote

Copy link
Copy Markdown
Contributor

It's only used for self.root_cx.root_def_id(), but self.infcx.root_def_id is also available.

r? @lqd

It's only used for `self.root_cx.root_def_id()`, but
`self.infcx.root_def_id` is also available.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 20, 2026
@chenyukang

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 93c8966 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 21, 2026
…, r=chenyukang

Remove `TypeChecker::root_cx`

It's only used for `self.root_cx.root_def_id()`, but `self.infcx.root_def_id` is also available.

r? @lqd
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
Rollup of 15 pull requests

Successful merges:

 - #161051 (When error from local macro, include macro def span)
 - #162750 (add case mapping fast paths for Latin-1)
 - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items)
 - #162835 (rustdoc: account for nested parens and split text events in bare urls lint)
 - #163044 (Report runtime range endpoints for runtime values)
 - #163062 (Use x30 register name with LLVM 23+)
 - #158102 (When compiling without a specified `--edition`, emit a note)
 - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`)
 - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`)
 - #163019 (Prepare for the introduction of forced keywords (`k#`))
 - #163020 (Dir: fix fallback impl for remove_dir)
 - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`)
 - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64)
 - #163079 (enable `f128` from `u64`/`i64` test)
 - #163082 (Remove `TypeChecker::root_cx`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 21, 2026
…, r=chenyukang

Remove `TypeChecker::root_cx`

It's only used for `self.root_cx.root_def_id()`, but `self.infcx.root_def_id` is also available.

r? @lqd
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #161051 (When error from local macro, include macro def span)
 - #161629 (Streamline `StateDiffCollector`)
 - #162750 (add case mapping fast paths for Latin-1)
 - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items)
 - #162835 (rustdoc: account for nested parens and split text events in bare urls lint)
 - #162952 (Depend on lockfiles to prevent GC of the current session)
 - #163044 (Report runtime range endpoints for runtime values)
 - #163062 (Use x30 register name with LLVM 23+)
 - #158102 (When compiling without a specified `--edition`, emit a note)
 - #162939 (Declare multi-kind constants for MacroKinds)
 - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`)
 - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`)
 - #163019 (Prepare for the introduction of forced keywords (`k#`))
 - #163020 (Dir: fix fallback impl for remove_dir)
 - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`)
 - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64)
 - #163079 (enable `f128` from `u64`/`i64` test)
 - #163082 (Remove `TypeChecker::root_cx`)
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - #161051 (When error from local macro, include macro def span)
 - #161629 (Streamline `StateDiffCollector`)
 - #162750 (add case mapping fast paths for Latin-1)
 - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items)
 - #162835 (rustdoc: account for nested parens and split text events in bare urls lint)
 - #162952 (Depend on lockfiles to prevent GC of the current session)
 - #163044 (Report runtime range endpoints for runtime values)
 - #163062 (Use x30 register name with LLVM 23+)
 - #163091 (miri subtree update)
 - #162939 (Declare multi-kind constants for MacroKinds)
 - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`)
 - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`)
 - #163019 (Prepare for the introduction of forced keywords (`k#`))
 - #163020 (Dir: fix fallback impl for remove_dir)
 - #163041 (Be more explicit on suggestion type without changing how they are rendered)
 - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`)
 - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64)
 - #163079 (enable `f128` from `u64`/`i64` test)
 - #163082 (Remove `TypeChecker::root_cx`)
@rust-bors
rust-bors Bot merged commit 43ad959 into rust-lang:main Sep 21, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 21, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
Rollup merge of #163082 - nnethercote:rm-TypeChecker-root_cx, r=chenyukang

Remove `TypeChecker::root_cx`

It's only used for `self.root_cx.root_def_id()`, but `self.infcx.root_def_id` is also available.

r? @lqd
@nnethercote
nnethercote deleted the rm-TypeChecker-root_cx branch September 21, 2026 22:00
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Sep 22, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - rust-lang/rust#161051 (When error from local macro, include macro def span)
 - rust-lang/rust#161629 (Streamline `StateDiffCollector`)
 - rust-lang/rust#162750 (add case mapping fast paths for Latin-1)
 - rust-lang/rust#162831 (Do not continue past `rustc_resolve` when encountering duplicated items)
 - rust-lang/rust#162835 (rustdoc: account for nested parens and split text events in bare urls lint)
 - rust-lang/rust#162952 (Depend on lockfiles to prevent GC of the current session)
 - rust-lang/rust#163044 (Report runtime range endpoints for runtime values)
 - rust-lang/rust#163062 (Use x30 register name with LLVM 23+)
 - rust-lang/rust#163091 (miri subtree update)
 - rust-lang/rust#162939 (Declare multi-kind constants for MacroKinds)
 - rust-lang/rust#162984 (Windows: don't error if `access_mode` is set on `OpenOptions`)
 - rust-lang/rust#163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`)
 - rust-lang/rust#163019 (Prepare for the introduction of forced keywords (`k#`))
 - rust-lang/rust#163020 (Dir: fix fallback impl for remove_dir)
 - rust-lang/rust#163041 (Be more explicit on suggestion type without changing how they are rendered)
 - rust-lang/rust#163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`)
 - rust-lang/rust#163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64)
 - rust-lang/rust#163079 (enable `f128` from `u64`/`i64` test)
 - rust-lang/rust#163082 (Remove `TypeChecker::root_cx`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants