Skip to content

Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten - #162839

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
guybedford:emscripten-min-4
Sep 29, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
guybedford:emscripten-min-4

Conversation

@guybedford

Copy link
Copy Markdown
Contributor

This documents Emscripten 4.0.0 as the minimum supported version, and removes the on-by-default -sWASM_BIGINT link argument from the wasm32-unknown-emscripten target spec.

WASM_BIGINT has been enabled by default since Emscripten 4.0.0 (January 2025), and newer Emscripten versions now emit a deprecation warning whenever it is set explicitly (emscripten-core/emscripten#27558), so every link through rustc currently produces a warning. Since Emscripten's warning categories are not fine-grained enough to suppress this one setting without also disabling -Wdeprecated in general, the cleanest fix is to drop the flag and rely on the default.

  • -sWASM_BIGINT removed from the target's post-link args (-sABORTING_MALLOC=0 is retained)
  • Platform support docs updated to state the Emscripten 4.0.0 minimum, with the install snippet using latest rather than pinning 3.1.68

Rust CI already installs the latest Emscripten release, so no CI changes are needed. Users on Emscripten < 4.0.0 who rely on the prebuilt std would need to upgrade or pass -C link-arg=-sWASM_BIGINT explicitly.

@rustbot

rustbot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2026
@rustbot

rustbot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 20 candidates

@madsmtm

madsmtm commented Sep 29, 2026

Copy link
Copy Markdown
Member

r? me

@rustbot rustbot assigned madsmtm and unassigned dingxiangfei2009 Sep 29, 2026
@madsmtm

madsmtm commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Target maintainer approves of this in #163441 (comment), so I feel confident in doing:

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8a82083 has been approved by madsmtm

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026
@madsmtm madsmtm added the O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! label Sep 29, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #163024 (Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`)
 - #162839 (Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten)
 - #163370 (Fix incorrect typo suggestion for `struct field` shorthands)
 - #163471 (do not suggest capturing `'_` twice in `use<...>` for E0700)
@rust-bors
rust-bors Bot merged commit 1dfcd5e into rust-lang:main Sep 29, 2026
13 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Sep 29, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026
Rollup merge of #162839 - guybedford:emscripten-min-4, r=madsmtm

Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten

This documents Emscripten 4.0.0 as the minimum supported version, and removes the on-by-default `-sWASM_BIGINT` link argument from the `wasm32-unknown-emscripten` target spec.

`WASM_BIGINT` has been enabled by default since Emscripten 4.0.0 (January 2025), and newer Emscripten versions now emit a deprecation warning whenever it is set explicitly (emscripten-core/emscripten#27558), so every link through rustc currently produces a warning. Since Emscripten's warning categories are not fine-grained enough to suppress this one setting without also disabling `-Wdeprecated` in general, the cleanest fix is to drop the flag and rely on the default.

* `-sWASM_BIGINT` removed from the target's post-link args (`-sABORTING_MALLOC=0` is retained)
* Platform support docs updated to state the Emscripten 4.0.0 minimum, with the install snippet using `latest` rather than pinning 3.1.68

Rust CI already installs the latest Emscripten release, so no CI changes are needed. Users on Emscripten < 4.0.0 who rely on the prebuilt `std` would need to upgrade or pass `-C link-arg=-sWASM_BIGINT` explicitly.
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Sep 30, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#163024 (Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`)
 - rust-lang/rust#162839 (Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten)
 - rust-lang/rust#163370 (Fix incorrect typo suggestion for `struct field` shorthands)
 - rust-lang/rust#163471 (do not suggest capturing `'_` twice in `use<...>` for E0700)
@guybedford
guybedford deleted the emscripten-min-4 branch October 2, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emscripten linker stderr: deprecated -sWASM_BIGINT

4 participants