Repository navigation
Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten - #162839
Merged
Conversation
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? me |
Member
|
Target maintainer approves of this in #163441 (comment), so I feel confident in doing: @bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
…uwer Rollup of 4 pull requests Successful merges: - #163024 (Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`) - #162839 (Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten) - #163370 (Fix incorrect typo suggestion for `struct field` shorthands) - #163471 (do not suggest capturing `'_` twice in `use<...>` for E0700)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Rollup merge of #162839 - guybedford:emscripten-min-4, r=madsmtm Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten This documents Emscripten 4.0.0 as the minimum supported version, and removes the on-by-default `-sWASM_BIGINT` link argument from the `wasm32-unknown-emscripten` target spec. `WASM_BIGINT` has been enabled by default since Emscripten 4.0.0 (January 2025), and newer Emscripten versions now emit a deprecation warning whenever it is set explicitly (emscripten-core/emscripten#27558), so every link through rustc currently produces a warning. Since Emscripten's warning categories are not fine-grained enough to suppress this one setting without also disabling `-Wdeprecated` in general, the cleanest fix is to drop the flag and rely on the default. * `-sWASM_BIGINT` removed from the target's post-link args (`-sABORTING_MALLOC=0` is retained) * Platform support docs updated to state the Emscripten 4.0.0 minimum, with the install snippet using `latest` rather than pinning 3.1.68 Rust CI already installs the latest Emscripten release, so no CI changes are needed. Users on Emscripten < 4.0.0 who rely on the prebuilt `std` would need to upgrade or pass `-C link-arg=-sWASM_BIGINT` explicitly.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Sep 30, 2026
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#163024 (Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`) - rust-lang/rust#162839 (Bump min Emscripten version to 4.0, drop deprecated -sWASM_BIGINT for wasm32-unknown-emscripten) - rust-lang/rust#163370 (Fix incorrect typo suggestion for `struct field` shorthands) - rust-lang/rust#163471 (do not suggest capturing `'_` twice in `use<...>` for E0700)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents Emscripten 4.0.0 as the minimum supported version, and removes the on-by-default
-sWASM_BIGINTlink argument from thewasm32-unknown-emscriptentarget spec.WASM_BIGINThas been enabled by default since Emscripten 4.0.0 (January 2025), and newer Emscripten versions now emit a deprecation warning whenever it is set explicitly (emscripten-core/emscripten#27558), so every link through rustc currently produces a warning. Since Emscripten's warning categories are not fine-grained enough to suppress this one setting without also disabling-Wdeprecatedin general, the cleanest fix is to drop the flag and rely on the default.-sWASM_BIGINTremoved from the target's post-link args (-sABORTING_MALLOC=0is retained)latestrather than pinning 3.1.68Rust CI already installs the latest Emscripten release, so no CI changes are needed. Users on Emscripten < 4.0.0 who rely on the prebuilt
stdwould need to upgrade or pass-C link-arg=-sWASM_BIGINTexplicitly.