Use hello_world instead of the guessing_game #16175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| src/guessing_game.rs:2:9: 2:10 warning: unused variable: `x`, #[warn(unused_variable)] on by default | ||
| src/guessing_game.rs:2 let x: int; | ||
| ^ | ||
| Compiling hello_world v0.1.0 (file:/home/you/projects/hello_world) |
There was a problem hiding this comment.
Does cargo really emit a bad file URL like that? file:/home/... is not correct, it should be file:///home/... (or sometimes file://home/... but that's not actually technically correct). I'd test it but I don't currently have cargo installed.
There was a problem hiding this comment.
@kballard Yes it does, this was my output:
Compiling hello_world v0.1.0 (file:/Users/eduardobautista/Projects/rust-guide)
There was a problem hiding this comment.
Yes, because currently rust-url is not compatible with windows paths
|
r+=me |
bors
added a commit
that referenced
this pull request
Aug 2, 2014
…ng-early, r=steveklabnik Solves: #16162
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2024
fix: Correctly set and mark the proc-macro spans This slows down analysis by 2-3s on self for me unfortunately (~2.5% slowdown) Noisy diff due to two simple refactoring in the first 2 commits. Relevant changes are [7d762d1](rust-lang/rust-analyzer@7d762d1) and [1e1113c](rust-lang/rust-analyzer@1e1113c) which introduce def site spans and correct marking for proc-macros respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #16162