Add regression test to cover additional cases by KevinA-cpu · Pull Request #161412 · rust-lang/rust

KevinA-cpu · 2026-08-20T16:55:45Z

closes #53048

Tests to cover rustc_parse\src\parser\mod.rs:187

m!(::core::clone::Clone)
m!(::), m!(1 + 1), m!(::foo)
#[derive(core::clone::Clone)]
#[derive(::core::clone::Clone)]

Tests to cover rustc_ast\src\attr\mod.rs

m!(a(::b::c))

Others

#[derive(Clone, ::core::marker::Copy)] — refutes the issue's implication that only a first list element failed.
#[cfg_attr(true, derive(::core::clone::Clone))] pub struct G; — covers the post-expansion re-parse route.

rustbot · 2026-08-20T16:55:50Z

Thanks for the pull request, and welcome! The Rust Project has assigned @fee1-dead (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 17 candidates

fee1-dead · 2026-08-26T00:43:18Z

r? fmease

rustbot · 2026-09-19T23:25:55Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

fmease · 2026-09-19T23:28:37Z

Looks like you fixed the bug underlying the CI failure in PR #162246. I've rebased for you.

fmease · 2026-09-19T23:39:07Z

+
+macro_rules! m { ($m:meta) => { #[derive($m)] pub struct S; }; }
+
+m!(a(::b::c));


Now also exercised in tests/ui/macros/correct-meta-item-span.rs, so I would remove it here (and keep the other one).

View changes since the review

fmease · 2026-09-19T23:39:28Z

+// This test ensures that invalid meta item or global path
+// is rejected by the compiler.
+
+extern crate core;


Not needed IINM.

View changes since the review

fmease · 2026-09-19T23:40:44Z

I would move into the other FAIL test file.

View changes since the review

fmease · 2026-09-19T23:42:09Z

+//~^ ERROR expected identifier, found `<eof>`
+
+// a meta item must begin with a path
+m!(1 + 1);


Does not relate to global paths, similarly for the other 3 cases below.

I'm pretty sure that we have preexisting tests that exercise that (at least I'd hope). I would need to go through rg ':\s*meta\b' tests/ui to confirm that.

View changes since the review

thanks @fmease you're right, I did the rg and found that:

tests/ui/macros/macro-meta-items.rs and tests/ui/macros/macro-meta-items-modern.rs already exercise general $meta:meta matching forms.

tests/ui/macros/attr-path-metavar-generic-args.rs specifically exercises path/metavariable generic arguments restrictions.

tests/ui/parser/attribute/attr-bad-meta-4.rs and related parser tests cover syntax errors on invalid attribute/meta positions.

I will remove those cases

KevinA-cpu · 2026-10-05T11:26:26Z

@rustbot ready

fmease

Thanks for applying my feedback and for your patience!

@bors rollup
@bors r+ squash

View changes since this review

* Add regression test to cover additional cases * Update tests/ui/macros/meta-item-global-path-issue-53048.rs * refactor: addressing comments Co-authored-by: Bang Ly <bang.ly@keyloop.com> Co-authored-by: Heisenburg <kevinanderson1410@gmail.com> Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>

rust-bors · 2026-10-09T18:06:14Z

🔨 3 commits were squashed into ec0f940.

rust-bors · 2026-10-09T18:06:16Z

📌 Commit ec0f940 has been tentatively approved by fmease

It will be put into the queue for this repository once PR CI succeeds.

…uwer Rollup of 3 pull requests Successful merges: - #164033 ( rustdoc: check reexport chain if inline before hidden) - #161412 (Add regression test to cover additional cases) - #164029 (Add a doc-comment for `rustc_ast_pretty::pprust::crate_to_string_for_macros`)

Rollup merge of #161412 - KevinA-cpu:regression-test-53048, r=fmease Add regression test to cover additional cases closes #53048 1. Tests to cover rustc_parse\src\parser\mod.rs:187 - m!(::core::clone::Clone) - m!(::), m!(1 + 1), m!(<T>::foo) - #[derive(core::clone::Clone)] - #[derive(::core::clone::Clone)] 2. Tests to cover rustc_ast\src\attr\mod.rs - m!(a(::b::c)) 3. Others - #[derive(Clone, ::core::marker::Copy)] — refutes the issue's implication that only a first list element failed. - #[cfg_attr(true, derive(::core::clone::Clone))] pub struct G; — covers the post-expansion re-parse route.

KevinA-cpu · 2026-10-12T03:50:45Z

@fmease thank you for giving me feedback and for your patience as well

rustbot assigned fee1-dead Aug 20, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2026

This comment has been minimized.

Sign in to view

KevinA-cpu mentioned this pull request Aug 21, 2026

[ICE]: Macro captures a list meta item with $m:meta and passes it directly to #[derive] causes must not be empty and have no suggestion #161472

Closed

rustbot assigned fmease and unassigned fee1-dead Aug 26, 2026

fmease force-pushed the regression-test-53048 branch from 99d9c1b to 82b821b Compare September 19, 2026 23:25

fmease reviewed Sep 19, 2026

View reviewed changes

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2026

fmease approved these changes Oct 9, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the regression-test-53048 branch from 052c62b to ec0f940 Compare October 9, 2026 18:06

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2026

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 3 pull requests #164061

Merged

rust-bors Bot merged commit 5e803f2 into rust-lang:main Oct 10, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 10, 2026


		macro_rules! m { ($m:meta) => { #[derive($m)] pub struct S; }; }

		m!(a(::b::c));

Conversation

KevinA-cpu commented Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 20, 2026

Uh oh!

This comment has been minimized.

fee1-dead commented Aug 26, 2026

Uh oh!

rustbot commented Sep 19, 2026

Uh oh!

fmease commented Sep 19, 2026

Uh oh!

fmease Sep 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinA-cpu Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

fmease Sep 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinA-cpu Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

fmease Sep 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinA-cpu Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fmease Sep 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinA-cpu Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

KevinA-cpu commented Oct 5, 2026

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

KevinA-cpu commented Oct 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KevinA-cpu commented Aug 20, 2026 •

edited by rustbot

Loading

fmease Sep 19, 2026 •

edited by rustbot

Loading

fmease Sep 19, 2026 •

edited by rustbot

Loading

fmease Sep 19, 2026 •

edited by rustbot

Loading

fmease Sep 19, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading