Tighten the language used for documenting TargetOptions::llvm_abiname - #161283
Merged
Conversation
`MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JohnTitor
approved these changes
Aug 19, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 19, 2026
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 19, 2026
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
…uwer Rollup of 16 pull requests Successful merges: - #159071 ([PAC] Encoder and hash (1/8)) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161332 (Some `GlobalCtxt`/`Session` cleanups) - #161344 (Update the `rustc-perf` submodule) - #150931 (rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied) - #160582 (Add `remove hidden_glob_reexports item breaks downstream` test) - #160876 (remove unwrap from write_mir_fn_graphviz) - #160927 (Enhance EII UI tests) - #161070 (fix arm homogeneous aggregate ABI) - #161236 (Download auto jobs in citool in parallel) - #161254 (Reserve capacity for 3% anon nodes) - #161283 (Tighten the language used for documenting `TargetOptions::llvm_abiname`) - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - #161299 (Remove a bunch of unnecessary explicit lifetimes) - #161307 (make ARM maintainers pingable) - #161308 (Add regression test for rustc diagnostic to recognize variables in match guards)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 19, 2026
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
…uwer Rollup of 16 pull requests Successful merges: - #159071 ([PAC] Encoder and hash (1/8)) - #161068 (Ensure TLS accesses don't call the global allocator through panic (part 3) ) - #161332 (Some `GlobalCtxt`/`Session` cleanups) - #161344 (Update the `rustc-perf` submodule) - #150931 (rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied) - #160582 (Add `remove hidden_glob_reexports item breaks downstream` test) - #160876 (remove unwrap from write_mir_fn_graphviz) - #160927 (Enhance EII UI tests) - #161070 (fix arm homogeneous aggregate ABI) - #161236 (Download auto jobs in citool in parallel) - #161254 (Reserve capacity for 3% anon nodes) - #161283 (Tighten the language used for documenting `TargetOptions::llvm_abiname`) - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - #161299 (Remove a bunch of unnecessary explicit lifetimes) - #161307 (make ARM maintainers pingable) - #161308 (Add regression test for rustc diagnostic to recognize variables in match guards)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 19, 2026
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 20, 2026
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
This was referenced Aug 20, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
…uwer Rollup of 26 pull requests Successful merges: - #161384 (Bust sccache's cache) - #161325 (Bump bootstrap to 1.99.0-beta.1) - #161344 (Update the `rustc-perf` submodule) - #161366 (Subtree sync for rustc_codegen_cranelift) - #159071 ([PAC] Encoder and hash (1/8)) - #160639 ([rustdoc] Only generate search DOM elements if the search is actually needed) - #161068 (Ensure TLS accesses don't call the global allocator through panic (part 3) ) - #161332 (Some `GlobalCtxt`/`Session` cleanups) - #150931 (rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied) - #158999 (doc: list all remove_dir_all fallback targets) - #160582 (Add `remove hidden_glob_reexports item breaks downstream` test) - #160876 (remove unwrap from write_mir_fn_graphviz) - #160927 (Enhance EII UI tests) - #161070 (fix arm homogeneous aggregate ABI) - #161190 (fix crash in async-drop and async-gen) - #161236 (Download auto jobs in citool in parallel) - #161254 (Reserve capacity for 3% anon nodes) - #161283 (Tighten the language used for documenting `TargetOptions::llvm_abiname`) - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - #161293 (add relnotes 1.98.0) - #161299 (Remove a bunch of unnecessary explicit lifetimes) - #161307 (make ARM maintainers pingable) - #161308 (Add regression test for rustc diagnostic to recognize variables in match guards) - #161346 (Don't rely on std traits not being const in tests) - #161360 (vec: fixup the name that i forgot) - #161367 (Reflect current PR title names for subtree syncs in triagebot no-merges)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
Rollup merge of #161283 - jchlanda:jakub/MCTargetOptions, r=JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 21, 2026
…uwer Rollup of 26 pull requests Successful merges: - rust-lang/rust#161384 (Bust sccache's cache) - rust-lang/rust#161325 (Bump bootstrap to 1.99.0-beta.1) - rust-lang/rust#161344 (Update the `rustc-perf` submodule) - rust-lang/rust#161366 (Subtree sync for rustc_codegen_cranelift) - rust-lang/rust#159071 ([PAC] Encoder and hash (1/8)) - rust-lang/rust#160639 ([rustdoc] Only generate search DOM elements if the search is actually needed) - rust-lang/rust#161068 (Ensure TLS accesses don't call the global allocator through panic (part 3) ) - rust-lang/rust#161332 (Some `GlobalCtxt`/`Session` cleanups) - rust-lang/rust#150931 (rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied) - rust-lang/rust#158999 (doc: list all remove_dir_all fallback targets) - rust-lang/rust#160582 (Add `remove hidden_glob_reexports item breaks downstream` test) - rust-lang/rust#160876 (remove unwrap from write_mir_fn_graphviz) - rust-lang/rust#160927 (Enhance EII UI tests) - rust-lang/rust#161070 (fix arm homogeneous aggregate ABI) - rust-lang/rust#161190 (fix crash in async-drop and async-gen) - rust-lang/rust#161236 (Download auto jobs in citool in parallel) - rust-lang/rust#161254 (Reserve capacity for 3% anon nodes) - rust-lang/rust#161283 (Tighten the language used for documenting `TargetOptions::llvm_abiname`) - rust-lang/rust#161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - rust-lang/rust#161293 (add relnotes 1.98.0) - rust-lang/rust#161299 (Remove a bunch of unnecessary explicit lifetimes) - rust-lang/rust#161307 (make ARM maintainers pingable) - rust-lang/rust#161308 (Add regression test for rustc diagnostic to recognize variables in match guards) - rust-lang/rust#161346 (Don't rely on std traits not being const in tests) - rust-lang/rust#161360 (vec: fixup the name that i forgot) - rust-lang/rust#161367 (Reflect current PR title names for subtree syncs in triagebot no-merges)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCOptionsis the name of the variable commonly used for instances ofMCTargetOptions. Use the proper type name instead. It should make finding the documentation for the struct a bit easier.