New Guide: crates and modules #15956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
**crates**, and **module**s doesn't seem to be rendered at least in github's preview
Contributor
Author
There was a problem hiding this comment.
I've used it elsewhere, so it does work.
Contributor
There was a problem hiding this comment.
Might be that it doesn't like star delimiters in the middle of a word.
Anyways, I'd suggest to embold the whole word. Bold makes the letters wider so having just a part emboldened seems just weird.
Contributor
Author
|
I've squashed this up, if we're happy with that last sentence, this is good to go. |
Contributor
Author
|
Whoops. Fixed the one test failure. |
bors
added a commit
that referenced
this pull request
Jul 29, 2014
Also fixes a couple of filesystem references that I forgot to change. 😅
Contributor
There was a problem hiding this comment.
"the mod declaration" is at best ambiguous here. It could be interpreted as referring to the mod decl in lib.rs, which of course cannot be omitted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2023
Improve completion label details display This PR improves completion label details display by separating trait and alias info from the `label` LSP field to an additional existing `label_detail` field. Changes look like the following: ### Before  ### After  _All existing tests are passed without any changes in test themselves logic._
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2023
fix: add fallback for completion label details This PR adds a fallback to a previous implementation in a case when the label detail field isn't supported by LSP client and the support isn't reported by the LSP initialize request. In this case additional info about trait and aliases would be merged into the label field as it was before the rust-lang#15956 PR.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
…lify (rust-lang#15956) The last two commits could arguably be split off into a separate PR -- let me know if that's desired. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a couple of filesystem references that I forgot to change. 😅