bootstrap: Rename std_crates_for_run_make to std_crates_for_make_run#159274
Open
Zalathar wants to merge 1 commit into
Open
bootstrap: Rename std_crates_for_run_make to std_crates_for_make_run#159274Zalathar wants to merge 1 commit into
std_crates_for_run_make to std_crates_for_make_run#159274Zalathar wants to merge 1 commit into
Conversation
This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests.
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Jul 14, 2026
Member
There was a problem hiding this comment.
Yeah, thanks, I also noticed this but then forgot about it :D
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 14, 2026
…jieyouxu bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run` This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests. (I was getting jump-scared every time I saw it!) r? jieyouxu (or bootstrap)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 14, 2026
Rollup of 6 pull requests Successful merges: - #159251 (Bump rustc-perf submodule) - #159243 (inline Once wait and wait_force) - #159255 (Replace shortened type with `_` instead of `...` as placeholder) - #159259 (Add regression test for #144033) - #159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable) - #159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
…jieyouxu bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run` This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests. (I was getting jump-scared every time I saw it!) r? jieyouxu (or bootstrap)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
…jieyouxu bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run` This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests. (I was getting jump-scared every time I saw it!) r? jieyouxu (or bootstrap)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
…jieyouxu bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run` This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests. (I was getting jump-scared every time I saw it!) r? jieyouxu (or bootstrap)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 14, 2026
…jieyouxu bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run` This function's name is referring to `Step::make_run`, and has nothing to do with run-make tests. (I was getting jump-scared every time I saw it!) r? jieyouxu (or bootstrap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function's name is referring to
Step::make_run, and has nothing to do with run-make tests.(I was getting jump-scared every time I saw it!)
r? jieyouxu (or bootstrap)