Fixes for QNX SDP 8 by jonathanpallant · Pull Request #158697 · rust-lang/rust

jonathanpallant · 2026-07-02T16:07:53Z

This PR contains libstd fixes so libstd can be build for QNX SDP 8.

It requires patches to libc-0.2 and cc-rs. The cc-rs patch was merged already. I have a patch for libc-1.0 here which will need backporting to libc-0.2 once merged.

With these in place, I was able to remotely test tests/ui library/std library/alloc library/core for x86_64-pc-qnx using a remote-test-server running on QNX SDP 8.0's QEMU BSP image. The only tests that failed were the two tests/ui/codegen/huge-stacks.rs tests, and I did not have enough RAM to run them.

rustbot · 2026-07-02T16:07:56Z

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-07-02T16:07:59Z

r? @aapoalas

rustbot has assigned @aapoalas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 13 candidates
Random selection from 6 candidates

rustbot · 2026-07-02T16:12:31Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

jonathanpallant · 2026-07-02T16:12:49Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

Removed.

aapoalas

Looks good to me from an "I know barely nothing about QNX and all that" standpoint.

Had a couple of questions or nits to pick that I'd like to see addressed.

View changes since this review

aapoalas · 2026-07-07T15:55:17Z

@bors squash

rust-bors · 2026-07-07T15:55:20Z

🔑 The Allow edits by maintainers option is not enabled on this PR. It is required for squashing to work.

aapoalas · 2026-07-07T15:56:51Z

Sorry @jonathanpallant could you squash the commits to one or few commits?

rustbot · 2026-07-07T15:57:07Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

aapoalas · 2026-07-07T15:58:22Z

r=me after squashing

@bors delegate+

rust-bors · 2026-07-07T15:58:26Z

✌️ @jonathanpallant, you can now approve this pull request!

If @aapoalas told you to "r=me" after making some further change, then please make that change and post @bors r=aapoalas.

View changes since this delegation.

1) setsid/setpgrp: check child's group process ID Linux [1], FreeBSD [2] and the Open Group [3] manuals for both setsid and setpgrp state that the calling process will be assigned a process group ID that matches its process ID so check that's the case in the test by calling getpgid on the child process ID. on QNX8 (as of GA8.0.2) libc::kill(pgid) appears unable to terminate the child process so skip that check on that target as it's behavior that libstd provides no API for [1]: https://man7.org/linux/man-pages/man2/setsid.2.html [2]: https://man.freebsd.org/cgi/man.cgi?query=setsid&sektion=2 [3]: https://pubs.opengroup.org/onlinepubs/000095399/functions/setsid.html 2) fix handling of sockaddr_un.len on QNX also extend the existing tests to exercise the getsockname(2) and getpeername(2) paths with both named and unnamed Unix sockets 3) Additional fixes library/std after earlier PR renamed some targets 4) Replace more instances of "QNX Neutrino / QNX OS" with "QNX SDP" and fix up some documentation URLs 5) Tests ignored on target_os = "nto" should also be ignored on target_os = "qnx". 6) Simplify nto-qnx.md documentation cc-rs now knows about QNX so the environment isn't required

jonathanpallant · 2026-07-07T16:33:02Z

@bors r=aapoalas

rust-bors · 2026-07-07T16:33:05Z

📌 Commit 49769af has been approved by aapoalas

It is now in the queue for this repository.

Fixes for QNX SDP 8 This PR contains libstd fixes so libstd can be build for QNX SDP 8. It requires patches to libc-0.2 and cc-rs. The cc-rs patch [was merged]([rust-lang/cc-rs#1775](rust-lang/cc-rs#1775)) already. I have a patch for libc-1.0 [here](rust-lang/libc#5241) which will need backporting to libc-0.2 once merged. With these in place, I was able to remotely `test tests/ui library/std library/alloc library/core` for `x86_64-pc-qnx` using a remote-test-server running on QNX SDP 8.0's QEMU BSP image. The only tests that failed were the two `tests/ui/codegen/huge-stacks.rs` tests, and I did not have enough RAM to run them.

…uwer Rollup of 18 pull requests Successful merges: - #157385 (Enable Enzyme on x86_64-apple) - #157561 (rustdoc: do not include extra stuff in span) - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158697 (Fixes for QNX SDP 8) - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - #157801 (Rewrite safety requirements for `Allocator` impls) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158841 (Avoid final override ICE for RPITIT associated types) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args)

…uwer Rollup of 19 pull requests Successful merges: - #156016 (view-types: store view types in the AST) - #157385 (Enable Enzyme on x86_64-apple) - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158697 (Fixes for QNX SDP 8) - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - #157801 (Rewrite safety requirements for `Allocator` impls) - #158085 (rustdoc: Fix sidebar heading order) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158841 (Avoid final override ICE for RPITIT associated types) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args) - #158922 (tests: clean up over-constraint on LLVM feature count) Failed merges: - #158617 (allow mGCA const arguments to fall back to anon consts)

Rollup merge of #158697 - ferrocene:qnx-sdp-8-fixes, r=aapoalas Fixes for QNX SDP 8 This PR contains libstd fixes so libstd can be build for QNX SDP 8. It requires patches to libc-0.2 and cc-rs. The cc-rs patch [was merged]([rust-lang/cc-rs#1775](rust-lang/cc-rs#1775)) already. I have a patch for libc-1.0 [here](rust-lang/libc#5241) which will need backporting to libc-0.2 once merged. With these in place, I was able to remotely `test tests/ui library/std library/alloc library/core` for `x86_64-pc-qnx` using a remote-test-server running on QNX SDP 8.0's QEMU BSP image. The only tests that failed were the two `tests/ui/codegen/huge-stacks.rs` tests, and I did not have enough RAM to run them.

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#156016 (view-types: store view types in the AST) - rust-lang/rust#157385 (Enable Enzyme on x86_64-apple) - rust-lang/rust#158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - rust-lang/rust#158621 (disallow `extern "custom"` on wasm and spirv targets) - rust-lang/rust#158690 (delegation: support mapping of all arguments with `Self` type) - rust-lang/rust#158696 (Rename some `body_id` to `body_def_id`) - rust-lang/rust#158697 (Fixes for QNX SDP 8) - rust-lang/rust#158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - rust-lang/rust#157801 (Rewrite safety requirements for `Allocator` impls) - rust-lang/rust#158085 (rustdoc: Fix sidebar heading order) - rust-lang/rust#158333 (Fix typetree generation for differentiated functions) - rust-lang/rust#158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - rust-lang/rust#158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - rust-lang/rust#158791 (Avoid unused braces lint for macro generated arguments) - rust-lang/rust#158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - rust-lang/rust#158841 (Avoid final override ICE for RPITIT associated types) - rust-lang/rust#158889 (tests: catch up with LLVM returning f128 on the stack) - rust-lang/rust#158905 (delegation: add constraints to new generic args) - rust-lang/rust#158922 (tests: clean up over-constraint on LLVM feature count) Failed merges: - rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)

rustbot assigned aapoalas Jul 2, 2026

This comment has been minimized.

Sign in to view

jonathanpallant force-pushed the qnx-sdp-8-fixes branch from a1eb41c to 826c18d Compare July 2, 2026 16:12

aapoalas approved these changes Jul 3, 2026

View reviewed changes

Comment thread library/std/src/sys/process/unix/common/tests.rs

Comment thread library/std/src/sys/thread_local/key/racy.rs Outdated

Comment thread tests/ui/abi/stack-probes.rs Outdated

aapoalas approved these changes Jul 3, 2026

View reviewed changes

aapoalas requested changes Jul 7, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026

jonathanpallant force-pushed the qnx-sdp-8-fixes branch from 8de1615 to 49769af Compare July 7, 2026 16:31

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 7, 2026

rust-bors Bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 7 pull requests #158919

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 18 pull requests #158923

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 19 pull requests #158924

Merged

rust-bors Bot merged commit 7fd8532 into rust-lang:main Jul 8, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 8, 2026

jonathanpallant mentioned this pull request Jul 9, 2026

Automated pull from upstream HEAD ferrocene/ferrocene#2447

Closed

Mark-Simulacrum mentioned this pull request Aug 8, 2026

std: fix unix socket address truncation without a trailing NUL #160416

Merged

Uh oh!

Uh oh!

Conversation

jonathanpallant commented Jul 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 2, 2026

Uh oh!

rustbot commented Jul 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jul 2, 2026

Uh oh!

jonathanpallant commented Jul 2, 2026

Uh oh!

aapoalas left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aapoalas commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

aapoalas commented Jul 7, 2026

Uh oh!

rustbot commented Jul 7, 2026

Uh oh!

aapoalas commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

jonathanpallant commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanpallant commented Jul 2, 2026 •

edited by rustbot

Loading

aapoalas left a comment •

edited by rustbot

Loading