Skip to content

Test updated GNU+mingw-w64 on CI - #156819

Closed
mati865 wants to merge 9 commits into
rust-lang:mainfrom
mati865:push-yqzvrrnpqylt
Closed

mati865 wants to merge 9 commits into
rust-lang:mainfrom
mati865:push-yqzvrrnpqylt

Conversation

@mati865

@mati865 mati865 commented May 22, 2026 •

Copy link
Copy Markdown
Member

View all comments

Function sections are broken even with latest toolchains.

TLS got fixed somewhere between 2.43..=2.46, still narrowing it down in Binutils 2.44: #156819 (comment).

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 22, 2026
@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@mati865
mati865 force-pushed the push-yqzvrrnpqylt branch from fa8e566 to 39353e8 Compare May 22, 2026 11:50
@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try cancel

@rust-bors

rust-bors Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

@rust-log-analyzer

This comment has been minimized.

@mati865
mati865 force-pushed the push-yqzvrrnpqylt branch from 39353e8 to c2c31df Compare May 22, 2026 12:02
@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-bors

rust-bors Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 682ad30 (682ad300e0fa926f9473e596d03bbf7858de98a8, parent: 3bf5c6d99bc8a0c0d5b2f69826ed4f6d256a0a21)

@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-bors

rust-bors Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b0ed8eb (b0ed8ebde04577c95f2bce16d1b6c9f884674de0, parent: 62f36da19c68978143da7ccc3e0926f90173a286)

@mati865

mati865 commented May 22, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@mati865 mati865 reopened this May 24, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 24, 2026
@mati865

mati865 commented May 24, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 24, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c8f7a30 failed: CI. Failed job:

@mati865

mati865 commented May 25, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 25, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0ba59e7 failed: CI. Failed jobs:

@mati865

mati865 commented May 25, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 25, 2026
Test updated GNU+mingw-w64 on CI


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@mati865

mati865 commented May 25, 2026

Copy link
Copy Markdown
Member Author

This will probably pass because the fix should be included in Binutils 2.44: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=72cd2c70977943054ff784b7278cef5262288f32

@rust-bors

rust-bors Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: dea5f51 (dea5f51379c9a5e9beff3dfeb49e30870185860b, parent: 6083f7891b5088184968e050d0eaecc7bcfd2b3d)

@mati865 mati865 closed this May 25, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 25, 2026
@mati865
mati865 deleted the push-yqzvrrnpqylt branch May 25, 2026 20:08
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 1, 2026
…enton

windows-gnu: enable native TLS

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: rust-lang#156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes rust-lang#91659
Fixes rust-lang#135719
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 1, 2026
…enton

windows-gnu: enable native TLS

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: rust-lang#156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes rust-lang#91659
Fixes rust-lang#135719
rust-bors Bot pushed a commit that referenced this pull request Oct 2, 2026
Rollup merge of #159021 - mati865:mingw-native-tls, r=ChrisDenton

windows-gnu: enable native TLS

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: #156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes #91659
Fixes #135719
LorrensP-2158466 pushed a commit to LorrensP-2158466/miri that referenced this pull request Oct 6, 2026
windows-gnu: enable native TLS

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: rust-lang/rust#156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes rust-lang/rust#91659
Fixes rust-lang/rust#135719
GauravPawar101 pushed a commit to GauravPawar101/rust-analyzer that referenced this pull request Oct 12, 2026
windows-gnu: enable native TLS

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: rust-lang/rust#156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes rust-lang/rust#91659
Fixes rust-lang/rust#135719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants