Parser: fix small PatIdent span bug #15428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix small bug introduced in e38cb97: PatIdent span was incorrect because self.last_span was being used before the ident token was parsed.
|
(I spotted this because it causes problems for racer's jump-to-definition functionality) |
bors
added a commit
that referenced
this pull request
Jul 5, 2014
Fix small bug introduced in e38cb97: PatIdent span was incorrect because self.last_span was being used before the ident token was parsed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
Fix pinned version of lsp-types lsp-types published a new patch version that breaks semver with the proposed feature set (this is intended and documented), we unfortunately forgot to specify the patch version for the pinned version so this breaks us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix small bug introduced in e38cb97: PatIdent span was incorrect
because self.last_span was being used before the ident token was
parsed.