Skip to content

Support Rust tab conventions in vim #15416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

wycats
Copy link
Contributor

@wycats wycats commented Jul 4, 2014

No description provided.

@wycats
Copy link
Contributor Author

wycats commented Jul 4, 2014

@alexcrichton r?

@steveklabnik
Copy link
Member

yes pls

@lilyball
Copy link
Contributor

lilyball commented Jul 4, 2014

This belongs in the ftplugin, not the ftdetect

We also already have an indent file that sets indentexpr, making the smartindent setting useless unless filetype indent is off.

@lilyball
Copy link
Contributor

lilyball commented Jul 4, 2014

I've submitted the correct implementation (in ftplugin) as #15429.

@lilyball
Copy link
Contributor

lilyball commented Jul 5, 2014

#15429 has been merged and makes this patch obsolete.

@lilyball lilyball closed this Jul 5, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2023
Display fully qualified associated types correctly

Currently they are formatted in the internal `Trait<Self = Type>::Assoc` forms where `hir_ty::TypeRef` is formatted, like hover.

There is no test of `TypeRef::hir_fmt` in crate `hir-ty` (verified by replacing it with a `panic!()`), most tests are about inference and printing the real `Ty` instead of `TypeRef`. So I added the test in `ide::hover`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants