Skip to content

rustdoc: Improve sentence for documented empty impl blocks #153020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Feb 24, 2026
+5 −4
Merged

rustdoc: Improve sentence for documented empty impl blocks #153020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/librustdoc/html/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2343,9 +2343,10 @@ fn render_impl_summary(
if let Some(doc) = doc {
if impl_is_empty {
w.write_str(
"<div class=\"item-info\">\
<div class=\"stab empty-impl\">This impl block contains no items.</div>\
</div>",
"\
<div class=\"item-info\">\
<div class=\"stab empty-impl\">This impl block contains no public items.</div>\
</div>",
)?;
}
write!(w, "<div class=\"docblock\">{doc}</div>")?;
Expand Down
2 changes: 1 addition & 1 deletion tests/rustdoc-html/impl/empty-impl-block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pub struct Foo;

//@ has - '//*[@class="docblock"]' 'Hello empty impl block!'
//@ has - '//*[@class="item-info"]' 'This impl block contains no items.'
//@ has - '//*[@class="item-info"]' 'This impl block contains no public items.'
/// Hello empty impl block!
impl Foo {}
// We ensure that this empty impl block without doc isn't rendered.
Expand Down
Loading