Stop using LinkedGraph in lexical_region_resolve#153012
Stop using LinkedGraph in lexical_region_resolve#153012Zalathar wants to merge 1 commit intorust-lang:mainfrom
LinkedGraph in lexical_region_resolve#153012Conversation
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
I don't expect this to be on a hot path for perf, but let's check. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stop using `LinkedGraph` in `lexical_region_resolve`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (71438fe): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.8%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 480.206s -> 480.109s (-0.02%) |
|
@bors rollup=maybe |
There are only two users of the older
LinkedGraphdata structure, and this is one.It turns out that this diagnostic-related code doesn't need any non-trivial graph operations (since it does its own graph traversal); it just needs the ability to get a list of in-edges or out-edges (constraints) for any particular node. That's easy enough to do with a simple custom data structure.
Inspired by #152621, which wants to make changes to
LinkedGraphthat wouldn't make sense for this use-site.