Skip to content

resolve: do not suggest _ for unresolved imports #152861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Feb 20, 2026
+3 −12
Merged

resolve: do not suggest _ for unresolved imports #152861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions compiler/rustc_resolve/src/imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
if i.name == ident.name {
return None;
} // Never suggest the same name
if i.name == kw::Underscore {
return None;
} // `use _` is never valid

let resolution = resolution.borrow();
if let Some(name_binding) = resolution.best_decl() {
Expand Down
12 changes: 0 additions & 12 deletions tests/ui/resolve/underscore-bindings-disambiguators.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,12 @@ error[E0432]: unresolved import `X`
|
LL | use X as Y;
| ^^^^^^ no `X` in the root
|
help: a similar name exists in the module
|
LL - use X as Y;
LL + use _ as Y;
|

error[E0432]: unresolved import `Z`
--> $DIR/underscore-bindings-disambiguators.rs:26:5
|
LL | use Z as W;
| ^^^^^^ no `Z` in the root
|
help: a similar name exists in the module
|
LL - use Z as W;
LL + use _ as W;
|

error[E0080]: evaluation panicked: not yet implemented
--> $DIR/underscore-bindings-disambiguators.rs:19:19
Expand Down
Loading