Add bootstrap snapshot tests for {install, install src}#152840
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 20, 2026
Merged
Add bootstrap snapshot tests for {install, install src}#152840rust-bors[bot] merged 1 commit intorust-lang:mainfrom
install, install src}#152840rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
commented
Feb 19, 2026
Comment on lines
+3009
to
+3014
| "--set", &format!("install.prefix={}", ctx.normalized_dir()), | ||
| "--set", &format!("install.bindir={}", ctx.normalized_dir()), | ||
| "--set", &format!("install.libdir={}", ctx.normalized_dir()), | ||
| "--set", &format!("install.datadir={}", ctx.normalized_dir()), | ||
| "--set", &format!("install.mandir={}", ctx.normalized_dir()), | ||
| "--set", &format!("install.sysconfdir={}", ctx.normalized_dir()), |
Member
Author
There was a problem hiding this comment.
Remark: drive-by change to cover all of the install.*dirs + extract the common dir normalization logic.
clubby789
reviewed
Feb 19, 2026
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Oh right. Can't just normalize out the host I think. |
rustbot
added
S-waiting-on-author
And `install src` with `build.docs = false`.
jieyouxu
force-pushed
the
bootstrap-install-src-no-docs
branch
from
6d1bca3 to
a9e6a89
Compare
Member
Author
|
Removed the stray config file used for local testing, and fixed the snapshots to not use host normalization. |
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 20, 2026
…docs, r=clubby789
Add bootstrap snapshot tests for {`install`, `install src`}
And `install src` with `build.docs = false`.
This is mostly to get coverage for the baseline to make it easier to review rust-lang#150845.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
Rollup of 7 pull requests Successful merges: - #152057 (bootstrap: respect POSIX jobserver) - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring) - #152840 (Add bootstrap snapshot tests for {`install`, `install src`}) - #152846 (Clarify some variable names in the query proc-macro) - #152858 (Fix typo in doc for core::mem::type_info::Struct) - #152861 (resolve: do not suggest `_` for unresolved imports) - #152873 (std::ops::ControlFlow - use "a" before `Result`)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 20, 2026
…docs, r=clubby789
Add bootstrap snapshot tests for {`install`, `install src`}
And `install src` with `build.docs = false`.
This is mostly to get coverage for the baseline to make it easier to review rust-lang#150845.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
Rollup of 8 pull requests Successful merges: - #152057 (bootstrap: respect POSIX jobserver) - #152527 (Remove -Zemit-thin-lto flag) - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring) - #152840 (Add bootstrap snapshot tests for {`install`, `install src`}) - #152846 (Clarify some variable names in the query proc-macro) - #152858 (Fix typo in doc for core::mem::type_info::Struct) - #152861 (resolve: do not suggest `_` for unresolved imports) - #152873 (std::ops::ControlFlow - use "a" before `Result`)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152759 (Simpler `find_attr!()`) - #152057 (bootstrap: respect POSIX jobserver) - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring) - #152840 (Add bootstrap snapshot tests for {`install`, `install src`}) - #152844 (Rename `DepGraphQuery` to `RetainedDepGraph`) - #152846 (Clarify some variable names in the query proc-macro) - #152858 (Fix typo in doc for core::mem::type_info::Struct) - #152861 (resolve: do not suggest `_` for unresolved imports) - #152873 (std::ops::ControlFlow - use "a" before `Result`) - #152877 (std::ops::ControlFlow - use normal comment for internal methods) - #152883 (Deny final not followed by item)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And
install srcwithbuild.docs = false.This is mostly to get coverage for the baseline to make it easier to review #150845.