Skip to content

Comments

Add CURRENT_RUSTC_VERSION support for Clippy#152815

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
blyxyas:current-rustc-version-clippy
Feb 19, 2026
Merged

Add CURRENT_RUSTC_VERSION support for Clippy#152815
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
blyxyas:current-rustc-version-clippy

Conversation

@blyxyas
Copy link
Member

@blyxyas blyxyas commented Feb 18, 2026

We've been talking about this since Sept. 2022, finally decided to add the dreaded 1-line diff.

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Using.20CURRENT_RUSTC_VERSION.20in.20clippy.3A.3Aversion.3F/with/516468805

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Use.20CURRENT_RUSTC_VERSION.20for.20version.20attribute/with/299900715

Overrides the currently unmerged rust-lang/rust-clippy#14299

cc @rust-lang/clippy


This PR does not modify in any way the needed behaviour of T-Release when releasing (I hope)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@Mark-Simulacrum
Copy link
Member

Did you confirm locally that this works if you artificially add something that needs replacement to clippy?

@blyxyas
Copy link
Member Author

blyxyas commented Feb 18, 2026

I did, adding CURRENT_RUSTC_VERSION to src/tools/clippy/clippy_lints/src/zero_sized_map_values.rs and it was replaced by 1.95.0

@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks!

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 18, 2026

📌 Commit 6a8c42d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 19, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152558 (rustc_expand: improve diagnostics for non-repeatable metavars in repetition)
 - #152596 (Make all multipart suggestions verbose)
 - #152815 (Add CURRENT_RUSTC_VERSION support for Clippy)
 - #152733 (Port #[rustc_doc_primitive] to the new attribute parser)
 - #152817 (Update enzyme submodule to match upstream)
 - #152819 (explicitly show behavior of <_>::assoc_fn)
 - #152823 (fix stale comments left over from ed3711e)
 - #152824 (Enable "View all comments" link feature in `triagebot.toml`)
@rust-bors rust-bors bot merged commit 6b227bb into rust-lang:main Feb 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 19, 2026
rust-timer added a commit that referenced this pull request Feb 19, 2026
Rollup merge of #152815 - blyxyas:current-rustc-version-clippy, r=Mark-Simulacrum

Add CURRENT_RUSTC_VERSION support for Clippy

We've been talking about this since Sept. 2022, finally decided to add the dreaded 1-line diff.

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Using.20CURRENT_RUSTC_VERSION.20in.20clippy.3A.3Aversion.3F/with/516468805

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Use.20CURRENT_RUSTC_VERSION.20for.20version.20attribute/with/299900715

Overrides the currently unmerged rust-lang/rust-clippy#14299

cc @rust-lang/clippy

---

This PR does not modify in any way the needed behaviour of T-Release when releasing (I hope)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants