Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Feb 11, 2026

Successful merges:

r? @ghost

Create a similar rollup

tshepang and others added 30 commits February 3, 2026 01:18
Automated labeling for date reference triage issue
Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
Fix rustdoc links for BoundRegionKind/BoundTyKind
Add cross-links between feature gate docs
Update diagnostics documentation
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustc-dev-guide Area: rustc-dev-guide A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 11, 2026
@Urgau
Copy link
Member Author

Urgau commented Feb 11, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 11, 2026

📌 Commit 452e85a has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

☀️ Test successful - CI
Approved by: Urgau
Duration: 3h 12m 27s
Pushing 605f49b to main...

@rust-bors rust-bors bot merged commit 605f49b into rust-lang:main Feb 12, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 12, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#137487 Stabilize assert_matches 9a42ca30e44f8f2ef329232d6aac94bb9411f9ac (link)
#151142 Support ADT types in type info reflection a12724e6e29146086236ab9517377906412519ff (link)
#152281 borrowck: suggest &mut *x for pattern reborrows c6e0cda63a3d006a4b65fa6404c8f069e17b1843 (link)
#152477 rustc-dev-guide subtree update af8d821cef667653cd5a933529a78408806e29ec (link)
#152488 allow deprecated(since = "CURRENT_RUSTC_VERSION") 159701b01ae3a641b78b7df2f3e3d206189abcd6 (link)
#152491 Remove unused fluent-syntax dependency from tidy d9d94a252e932577048cc130b247c9eadeeedf10 (link)
#152505 Sync relnotes for stable 1.93.1 1f63a60ae50afa1af77a83374dc2134dc8d61f72 (link)

previous master: 5fdff787e6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5fdff78 (parent) -> 605f49b (this PR)

Test differences

Show 186 test diffs

Stage 1

  • mem::type_info::test_enums: [missing] -> pass (J1)
  • mem::type_info::test_structs: [missing] -> pass (J1)
  • mem::type_info::test_unions: [missing] -> pass (J1)
  • [ui] tests/ui/borrowck/reborrow-in-match-suggest-deref.rs: [missing] -> pass (J2)
  • [ui] tests/ui/reflection/dump.rs#bit32: ignore (only executed when the pointer width is 32bit) -> [missing] (J2)
  • [ui] tests/ui/reflection/dump.rs#bit64: pass -> [missing] (J2)

Stage 2

  • mem::type_info::test_enums: [missing] -> pass (J0)
  • mem::type_info::test_structs: [missing] -> pass (J0)
  • mem::type_info::test_unions: [missing] -> pass (J0)
  • [ui] tests/ui/reflection/dump.rs#bit32: ignore (only executed when the pointer width is 32bit) -> [missing] (J3)
  • [ui] tests/ui/reflection/dump.rs#bit64: pass -> [missing] (J3)
  • [ui] tests/ui/reflection/dump.rs#bit32: pass -> [missing] (J4)
  • [ui] tests/ui/reflection/dump.rs#bit64: ignore (only executed when the pointer width is 64bit) -> [missing] (J4)
  • [ui] tests/ui/borrowck/reborrow-in-match-suggest-deref.rs: [missing] -> pass (J5)

Additionally, 172 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 605f49b27444a738ea4032cb77e3bdc4eb811bab --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 5h 27m -> 2h 58m (-45.7%)
  2. dist-apple-various: 1h 52m -> 1h 35m (-15.2%)
  3. dist-powerpc-linux: 1h 21m -> 1h 31m (+11.9%)
  4. x86_64-msvc-ext2: 1h 33m -> 1h 43m (+10.9%)
  5. i686-gnu-nopt-1: 2h 18m -> 2h 3m (-10.8%)
  6. dist-x86_64-msvc-alt: 2h 32m -> 2h 47m (+9.8%)
  7. x86_64-gnu-distcheck: 2h 7m -> 2h 18m (+8.5%)
  8. pr-check-1: 30m 49s -> 33m 22s (+8.3%)
  9. test-various: 2h 3m -> 1h 53m (-8.0%)
  10. dist-aarch64-llvm-mingw: 1h 52m -> 2h 1m (+7.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (605f49b): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
0.2% [0.1%, 0.2%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.2%, -0.1%] 2
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary 1.0%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.0% [0.6%, 1.7%] 3
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.8% [-5.2%, -4.4%] 2
All ❌✅ (primary) 1.0% [0.6%, 1.7%] 3

Cycles

Results (primary -2.3%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
7.5% [2.5%, 12.4%] 2
Improvements ✅
(primary)
-2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)
-4.7% [-7.4%, -2.1%] 4
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.1%] 8
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 8

Bootstrap: 476.59s -> 473.252s (-0.70%)
Artifact size: 397.90 MiB -> 395.87 MiB (-0.51%)

@rustbot rustbot added the perf-regression Performance regression. label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustc-dev-guide Area: rustc-dev-guide A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.