fix issue#152482 #152485
fix issue#152482 #152485
Conversation
rustbot
added
S-waiting-on-review
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
I also see open calls without specifying encoding= elsewhere in Python scripts. For example
rust/src/bootstrap/bootstrap.py
Line 1349 in d34f1f9
Would it be better to override the default locale to UTF-8 using CLI option -X utf8 or env var PYTHONUTF8? I'm not a Python expert, just wanted to bring this up.
We are unlikely to be able to rely on either approach, because the entry python scripts are not just run under CI conditions. |
| # Give a hard error if `--config` or `RUST_BOOTSTRAP_CONFIG` are set to a missing path, | ||
| # but not if `bootstrap.toml` hasn't been created. | ||
| if not using_default_path or os.path.exists(toml_path): | ||
| with open(toml_path) as config: |
There was a problem hiding this comment.
Remark: we should go through bootstrap.py and make sure we specific explicit open() encodings, as far as I am aware there is a reasonable desire to want to make a future change in Python 3.* where open() defaults to UTF-8 encoding, which could break open() on binary files called elsewhere in this script.
rust-bors
bot
added
S-waiting-on-bors
fix issue#152482 Close rust-lang#152482
Rollup of 17 pull requests Successful merges: - #142415 (Add note when inherent impl for a alias type defined outside of the crate) - #142680 (Fix passing/returning structs with the 64-bit SPARC ABI) - #150768 (Don't compute FnAbi for LLVM intrinsics in backends) - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151814 (layout: handle rigid aliases without params) - #151863 (Borrowck: simplify diagnostics for placeholders) - #152159 (Add note for `?Sized` params in int-ptr casts diag) - #152434 (Clarify names of `QueryVTable` functions for "executing" a query) - #152478 (Remove tm_factory field from CodegenContext) - #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place") - #152316 (fix: add continue) - #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter) - #152425 (Port #![test_runner] to the attribute parser) - #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif) - #152485 (fix issue#152482) - #152495 (Clean up some subdiagnostics) - #152502 (Implement `BinaryHeap::from_raw_vec`)
4 participants
Close #152482