Skip to content

Convert to inline diagnostics in rustc_passes #152189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 6, 2026
Merged

Convert to inline diagnostics in rustc_passes #152189

rust-bors merged 1 commit into from
Feb 6, 2026
+437 −843

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 5, 2026 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 5, 2026
Open
3 tasks
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lqd
Copy link
Member

lqd commented Feb 6, 2026

I'll also take this one, we're so close

r? me

@rustbot rustbot assigned lqd and unassigned jdonszelmann Feb 6, 2026
@lqd
Copy link
Member

lqd commented Feb 6, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

📌 Commit ea43035 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 6, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@bors
Auto merge of #152239 - JonathanBrouwer:rollup-2BolGX5, r=JonathanBro…
efc9e1b 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #152129 (MGCA: require #[type_const] on free consts too)
 - #152139 (mGCA: Support directly represented negated literals)
 - #152189 (Convert to inline diagnostics in `rustc_passes`)
@rust-bors rust-bors bot merged commit ce8d09b into rust-lang:main Feb 6, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 6, 2026
@rust-timer
Unrolled build for #152189
202ae33 
Rollup merge of #152189 - JonathanBrouwer:convert_passes, r=lqd

Convert to inline diagnostics in `rustc_passes`

For #151366
r? @jdonszelmann
@rustbot rustbot added this to the 1.95.0 milestone Feb 6, 2026
@github-actions github-actions bot mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @lqd @jdonszelmann