Distinguish error message for #[diagnostic::on_const] on const trait impls
#152054
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
diag_const_trait_impl
branch
from
58295ec to
dfc60ae
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 3, 2026
…, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: rust-lang#149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank
This was referenced Feb 3, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…uwer Rollup of 7 pull requests Successful merges: - #148967 (const-eval: always do mem-to-mem copies if there might be padding involved) - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script) - #152044 (Convert to inline diagnostics in `rustc_incremental`) - #152046 (Use glob imports for attribute parsers) - #152054 (Distinguish error message for `#[diagnostic::on_const]` on const trait impls) - #152059 (Fix some autodiff tests require Clto=fat) - #152073 (Convert to inline diagnostics in `rustc_mir_dataflow`)
rust-timer
added a commit
that referenced
this pull request
Feb 4, 2026
Rollup merge of #152054 - lapla-cogito:diag_const_trait_impl, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: #149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #149627 (comment)
Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it.
r? estebank