Skip to content

escape symbol names in global asm #151955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 6, 2026
Merged

escape symbol names in global asm #151955

rust-bors merged 1 commit into from
Feb 6, 2026
+91 −3

Conversation

@usamoi
Copy link
Contributor

@usamoi usamoi commented Feb 1, 2026

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2026
@usamoi usamoi marked this pull request as ready for review February 1, 2026 14:50
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

davidtwco commented Feb 5, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 5, 2026

📌 Commit b5d9b7f has been approved by davidtwco

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151955 - usamoi:escape, r=davidtwco
976f17d 
escape symbol names in global asm

copied from https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCSymbol.cpp

closes rust-lang#151950
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 5, 2026
Closed
@bjorn3
Copy link
Member

bjorn3 commented Feb 5, 2026

Shouldn't this also be applied to the other codegen backends?

rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152181 - JonathanBrouwer:rollup-A2QIb81, r=JonathanBro…
ba2ea18 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152181 - JonathanBrouwer:rollup-A2QIb81, r=JonathanBro…
221de4c 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151955 - usamoi:escape, r=davidtwco
729b31c 
escape symbol names in global asm

copied from https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCSymbol.cpp

closes rust-lang#151950
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 5, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152185 - JonathanBrouwer:rollup-JuaHm6e, r=JonathanBro…
a81e5df 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152174 (stdarch subtree update)
 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
 - #152184 (Port rustc_abi to the attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152185 - JonathanBrouwer:rollup-JuaHm6e, r=JonathanBro…
ce8d2f4 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152174 (stdarch subtree update)
 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
 - #152184 (Port rustc_abi to the attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152185 - JonathanBrouwer:rollup-JuaHm6e, r=JonathanBro…
41dca5b 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152174 (stdarch subtree update)
 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
 - #152184 (Port rustc_abi to the attribute parser)
@jieyouxu jieyouxu mentioned this pull request Feb 6, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@bors
Auto merge of #152200 - jieyouxu:rollup-UNFpgZy, r=jieyouxu
a3ceeeb 
Rollup of 4 pull requests

Successful merges:

 - #152174 (stdarch subtree update)
 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #152194 (Remove the 4 failing tests from rustdoc-gui)

Failed merges:

 - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
@rust-bors rust-bors bot merged commit 4a1e87c into rust-lang:main Feb 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 6, 2026
rust-timer added a commit that referenced this pull request Feb 6, 2026
@rust-timer
Unrolled build for #151955
7acd113 
Rollup merge of #151955 - usamoi:escape, r=davidtwco

escape symbol names in global asm

copied from https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCSymbol.cpp

closes #151950
@usamoi
Copy link
Contributor Author

usamoi commented Feb 6, 2026

Shouldn't this also be applied to the other codegen backends?

GCC backend doesn't support symbol names with special characters, so it doesn't work anyway, and it could not be tested. rustc_codegen_cranelift requires a feature gate called inline_asm_sym, so I'm guessing it's not ready yet?

@usamoi usamoi deleted the escape branch February 10, 2026 12:24
@github-actions github-actions bot mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

unmangled symbols are not escaped in naked/global assembly

5 participants

@usamoi @rustbot @rust-log-analyzer @davidtwco @bjorn3