Skip to content

Skip overlapping spans in argument error suggestions #151909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 3, 2026
Merged

Skip overlapping spans in argument error suggestions #151909

rust-bors merged 1 commit into from
Feb 3, 2026
+110 −1

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 31, 2026 •
edited by rustbot
Loading

Fixes #151607

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo Kivooeo assigned Kivooeo and unassigned jackh726 Jan 31, 2026
Kivooeo
Kivooeo reviewed Jan 31, 2026
View reviewed changes
tests/ui/argument-suggestions/disjoint-spans-issue-151607.stderr
Comment on lines +78 to +79
LL - foo(B, g, D, E, F, G)
LL + foo(, g, F, G)
Copy link
Member

@Kivooeo Kivooeo Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diagnostic is a bit sus

Copy link
Member

@Kivooeo Kivooeo Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to revisit this in a follow up pr maybe somewhere later?

Copy link
Member Author

@chenyukang chenyukang Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also noticed this, i'm working on another branch.

@Kivooeo
Copy link
Member

Kivooeo commented Feb 2, 2026

i guess its fine if we add this

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

📌 Commit 8c0d93b has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151909 - chenyukang:yukang-fix-151607-disjo…
eb32f2e 
…int-spans, r=Kivooeo

Skip overlapping spans in argument error suggestions

Fixes rust-lang#151607
This was referenced Feb 2, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
6c828e5 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
fc8438a 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 3, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
5ac8ece 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
@rust-bors rust-bors bot merged commit a34cb94 into rust-lang:main Feb 3, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 3, 2026
@rust-timer
Unrolled build for #151909
4394655 
Rollup merge of #151909 - chenyukang:yukang-fix-151607-disjoint-spans, r=Kivooeo

Skip overlapping spans in argument error suggestions

Fixes #151607
@github-actions github-actions bot mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo left review comments

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: all spans must be disjoint

4 participants

@chenyukang @rustbot @Kivooeo @jackh726