Add extern crate core to diagnostic tests
#151738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
3 tasks
Contributor
Author
|
r? Kivooeo |
rustbot
added
S-waiting-on-review
Contributor
Author
|
Oh my ci failed, one second :c |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
Was just a dumdum mistake, this should fix it |
rustbot
added
S-waiting-on-review
JonathanBrouwer
changed the title
extern crate core to diagnostic tests
Member
|
dumdum :) that's fine, we all do dumdum mistakes time to time |
Kivooeo
approved these changes
Jan 27, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2026
Add `extern crate core` to diagnostic tests We do this to solve the `failed to resolve: you might be missing crate core` messages that were previously visible in the stderr. We also split off `subdiagnostic-derive-2` from the main `subdiagnostic-derive`, because the error for this test is now generated post-expansion.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 6 pull requests Successful merges: - #151751 (`rust-analyzer` subtree update) - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151759 (Update `browser-ui-test` version to `0.23.3`)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2026
Add `extern crate core` to diagnostic tests We do this to solve the `failed to resolve: you might be missing crate core` messages that were previously visible in the stderr. We also split off `subdiagnostic-derive-2` from the main `subdiagnostic-derive`, because the error for this test is now generated post-expansion.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 6 pull requests Successful merges: - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151449 ([rustdoc] Add regression test for #151411) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151759 (Update `browser-ui-test` version to `0.23.3`)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 27, 2026
Add `extern crate core` to diagnostic tests We do this to solve the `failed to resolve: you might be missing crate core` messages that were previously visible in the stderr. We also split off `subdiagnostic-derive-2` from the main `subdiagnostic-derive`, because the error for this test is now generated post-expansion.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
Rollup of 6 pull requests Successful merges: - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151449 ([rustdoc] Add regression test for #151411) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151759 (Update `browser-ui-test` version to `0.23.3`)
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
Rollup of 9 pull requests Successful merges: - #151239 (Support trait objects in type info reflection) - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151747 (Update `askama` version to `0.15.2`) - #151759 (Update `browser-ui-test` version to `0.23.3`) - #151763 (Add FileCheck annotations to simplify_match.rs) - #151766 (Fix `x fix`, again)
rust-timer
added a commit
that referenced
this pull request
Jan 28, 2026
Rollup merge of #151738 - JonathanBrouwer:fix, r=Kivooeo Add `extern crate core` to diagnostic tests We do this to solve the `failed to resolve: you might be missing crate core` messages that were previously visible in the stderr. We also split off `subdiagnostic-derive-2` from the main `subdiagnostic-derive`, because the error for this test is now generated post-expansion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this to solve the
failed to resolve: you might be missing crate coremessages that were previously visible in the stderr.We also split off
subdiagnostic-derive-2from the mainsubdiagnostic-derive, because the error for this test is now generated post-expansion.