Fix contrast ratio for Since element in rustdoc dark theme
#151665
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-js
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Some changes occurred in GUI tests. |
This comment has been minimized.
This comment has been minimized.
11 tasks
Contributor
Author
|
@GuillaumeGomez I changed color from 
|
GuillaumeGomez
approved these changes
Jan 26, 2026
Member
|
Looks good to me, thanks! Please squash your commits then I'll put it into the build queue. |
Signed-off-by: Antonio Souza <arfs.antonio@gmail.com>
arferreira
force-pushed
the
fix-rustdoc-contrast
branch
from
a96e5a9 to
c7788af
Compare
Contributor
|
typo in commit and title? |
Member
|
What typo do you see? Also sorry, forgot to r+ it. r+ing in the meantime. @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 29, 2026
…=GuillaumeGomez Fix contrast ratio for `Since` element in rustodoc dark theme Changed `--right-side-color` from `#808080` to `#ababab` in the dark theme. <img width="742" height="784" alt="Screenshot 2026-01-25 at 8 04 29 PM" src="https://github.com/user-attachments/assets/38c5f0b9-2034-429f-87db-8a0ed8209b5d" /> Verified visually in dark theme, it's now more readable: <img width="174" height="96" alt="Screenshot 2026-01-25 at 8 41 02 PM" src="https://github.com/user-attachments/assets/d0c30409-4374-48c4-ae9c-a0aec48e8957" /> Part of rust-lang#59845 Fixes rust-lang#151422
Contributor
|
"rustodoc" no idea if this is a typo or i'm missing something. |
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
Rollup of 8 pull requests Successful merges: - #150474 (Tidy: detect ui tests subdirectory changes so `tests/ui/README.md` stays in sync) - #150572 (Improve move error diagnostic for `AsyncFn` closures) - #151596 (Fix -Zmir-enable-passes to detect unregistered enum names in declare_passes macro) - #151802 (Make `QueryDispatcher::Qcx` an associated type) - #151559 ([rustdoc] Add a marker to tell users that there are hidden (deprecated) items in the search results) - #151665 (Fix contrast ratio for `Since` element in rustodoc dark theme) - #151798 (Update `askama` to `0.15.3`) - #151800 (Subscribe myself to translation diagnostics)
arferreira
changed the title
Since element in rustodoc dark themeSince element in rustdoc dark theme
Contributor
Author
it was a typo on my PR title, commit looks okay, fixed title tho |
Contributor
|
Commit has the same typo |
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
Rollup of 12 pull requests Successful merges: - #150474 (Tidy: detect ui tests subdirectory changes so `tests/ui/README.md` stays in sync) - #150572 (Improve move error diagnostic for `AsyncFn` closures) - #151596 (Fix -Zmir-enable-passes to detect unregistered enum names in declare_passes macro) - #151802 (Make `QueryDispatcher::Qcx` an associated type) - #149110 (Implement `cast_slice` for raw pointer types) - #151559 ([rustdoc] Add a marker to tell users that there are hidden (deprecated) items in the search results) - #151665 (Fix contrast ratio for `Since` element in rustdoc dark theme) - #151785 (Stabilize feature(push_mut)) - #151798 (Update `askama` to `0.15.3`) - #151800 (Subscribe myself to translation diagnostics) - #151804 (Document, sort, and tweak spellcheck entries in `typos.toml`) - #151805 (Fix grammar in `env::current_exe()#Security`)
rust-timer
added a commit
that referenced
this pull request
Jan 29, 2026
Rollup merge of #151665 - arferreira:fix-rustdoc-contrast, r=GuillaumeGomez Fix contrast ratio for `Since` element in rustdoc dark theme Changed `--right-side-color` from `#808080` to `#ababab` in the dark theme. <img width="742" height="784" alt="Screenshot 2026-01-25 at 8 04 29 PM" src="https://github.com/user-attachments/assets/38c5f0b9-2034-429f-87db-8a0ed8209b5d" /> Verified visually in dark theme, it's now more readable: <img width="174" height="96" alt="Screenshot 2026-01-25 at 8 41 02 PM" src="https://github.com/user-attachments/assets/d0c30409-4374-48c4-ae9c-a0aec48e8957" /> Part of #59845 Fixes #151422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
--right-side-colorfrom#808080to#abababin the dark theme.Verified visually in dark theme, it's now more readable:
Part of #59845
Fixes #151422