Skip to content

Factor out diagnostic slug checking from DiagnosticDerive #151338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 2 commits into from
Jan 19, 2026
Merged

Factor out diagnostic slug checking from DiagnosticDerive #151338

rust-bors merged 2 commits into from
Jan 19, 2026
+67 −84

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jan 18, 2026

Doing some cleanup work in preparation for rust-lang/compiler-team#959

r? @Kivooeo

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@Kivooeo
Copy link
Member

Kivooeo commented Jan 18, 2026

so basically this removes some checks for ftl files?

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jan 18, 2026

This PR should not change observable behaviour.
The same is written twice for DiagnosticDerive and for LintDiagnosticDerive, this PR factors it into a method

@Kivooeo
Copy link
Member

Kivooeo commented Jan 18, 2026

ah, yeah i see it was duplicated, so now it's just a single method in DiagnosticDeriveVariantBuilder

Kivooeo
Kivooeo approved these changes Jan 18, 2026
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when ci is green

here is some style nits, if you like some of those you could apply them, otherwise feel free to ignore

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jan 19, 2026

@bors r=Kivooeo rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 7ec4a8e has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 19, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
@bors
Auto merge of #151360 - JonathanBrouwer:rollup-UpAM1gc, r=JonathanBro…
158ae9e 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151071 (Generate openmp metadata)
 - #151302 (add lint test)
 - #151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - #151354 (ci: Move lockfile updates to a script)

r? @ghost
@rust-bors rust-bors bot merged commit d2375c2 into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
@rust-timer
Unrolled build for #151338
fe7cc6a 
Rollup merge of #151338 - factor_slug, r=Kivooeo

Factor out diagnostic slug checking from `DiagnosticDerive`

Doing some cleanup work in preparation for rust-lang/compiler-team#959

r? @Kivooeo
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 19, 2026
Open
3 tasks
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151360 - JonathanBrouwer:rollup-UpAM1gc, r=JonathanBro…
6793500 
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151071 (Generate openmp metadata)
 - rust-lang/rust#151302 (add lint test)
 - rust-lang/rust#151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - rust-lang/rust#151354 (ci: Move lockfile updates to a script)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @Kivooeo @rust-log-analyzer