-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Enable outline-atomics by default on aarch64 Apple targets
#150745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors2 try jobs=aarch64-apple |
|
Unknown command "2". Run |
|
@vini-fda: 🔑 Insufficient privileges: not in try users |
|
@bors help |
|
You can use the following commands: PR management
Repository management
Meta commands
|
|
cc @tgross35 These commits modify compiler targets. |
|
r? tgross35 I finished commenting at #149634 just after you marked this ready for review, but as the above message says, the compiler-builtins bit should go against that repo so it gets the better test coverage. |
|
For splitting the asm part to the c-b repo and sending it there, |
|
Reminder, once the PR becomes ready for a review, use |
As a note: it's always fine to pick up somebody else's work or absorb somebody else's patches, but if you do this you should leave a Not just asking because the author of that patch happens to be me, I'm rigerous with this myself :) |
Summary
This PR is related to #149634. Most of the credit goes to tgross35@76a4adc.
Tests
I haven't added any tests, but I enabled the tests in
library/compiler-builtins/builtins-test/tests/lse.rsfor all operating systems. It was previously gated to Linux-only, but with this change these tests work for Apple as well (I performed local tests). I'm hoping other OSes also pass the tests.I ran the tests by running the following with rust-nightly (after running the
xscript and creating a stage 1 compiler):I followed the contributing guide for the tests, though I'm still struggling with testing. I would appreciate some pointers to learn how to use the test tools effectively for compiler-builtins.