-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
experiment: Add simple externally implementable item to std #150513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Enselic
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
Enselic:eei-in-std-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives lots of strange compilation errors. See https://gist.github.com/Enselic/c643f454515db6f10caa7ab04045ab32 for the full list.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-extern_item_impls
`#![feature(extern_item_impls)]`
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking into porting
-Zon-broken-pipe=...(tracking issue #97889) to use an externally implementable item instead.Trying to add an Externally Implementable Item to std results in lost of strange compilation errors. This PR contains this diff:
and gives > 800 compilation errors. The first three are below. See https://gist.github.com/Enselic/c643f454515db6f10caa7ab04045ab32 for the full list.
I am creating this PR just to demonstrate the problem to others so it's easier to discuss. See #150514.
Tracking Issue: #125418