Tidying up tests/ui/issues 16 tests [7/N]#150384
Conversation
|
This PR modifies |
rustbot
added
S-waiting-on-review
| @@ -1,8 +1,9 @@ | |||
| //@ run-pass | |||
| // Regression test for #20676. Error was that we didn't support | |||
| // UFCS-style calls to a method in `Trait` where `Self` was bound to a | |||
| // trait object of type `Trait`. See also `ufcs-trait-object.rs`. | |||
There was a problem hiding this comment.
ufcs-trait-object.rs had been renamed.
Considering the possibility of future changes, I changed it to point to the file of the current commit, but would it be better to set it to the commit when this file was created?
There was a problem hiding this comment.
Honestly, I don't have a strong opinion about this and am absolutely not familiar with UFCS
There was a problem hiding this comment.
Okay, I'll leave it as is.
There was a problem hiding this comment.
Not sure if this has anything to share with consts and const-eval, let's move it, whether to cast or if we have anything related to chars
There was a problem hiding this comment.
In issue #41998, I saw that the ICE log was coming from librustc_const_eval/eval.rs, so I placed it in the consts/const-eval directory.
Moved to cast\cast-to-char-compare.rs
delete tests/ui/issues/issue-22426.rs duplicated of tests/ui/match/guards.rs
There was a problem hiding this comment.
In issue #41998, I saw that the ICE log was coming from librustc_const_eval/eval.rs, so I placed it in the consts/const-eval directory.
Moved to cast\cast-to-char-compare.rs
tests/ui/README.md
Outdated
| ## `tests/ui/fn_traits/` | ||
|
|
||
| Tests for `#![feature(fn_traits)]`. See [`fn_traits` | The Unstable book](https://doc.rust-lang.org/nightly/unstable-book/library-features/fn-traits.html). | ||
|
|
There was a problem hiding this comment.
and I dropped this commit because it overlaps with changes in #150474
cleaned up cast-enum-const.rs cleaned up ufcs-trait-object-format.rs add comment to cast-to-box-arr.rs add comment to shadow-primitives.rs add comment to associated-type-const-nomalization.rs add comment to fn-trait-explicit-call.rs add comment to call-unit-struct-impl-fn-once.rs add comment to cast-to-char-compare.rs add comment to self-in-method-body-resolves.rs add comment to derive-debug-newtype-unsized-slice.rs add comment to tuple-ref-order-distinct-impls.rs add comment to derive-debug-generic-with-lifetime.rs add comment to recursive-trait-bound-on-type-param.rs cleaned up const-static-ref-to-closure.rs add comment to const-iter-no-conflict-for-loop.rs
|
thanks for working on it! @bors r+ rollup |
bors
added
S-waiting-on-bors
4 participants
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
r? Kivooeo