Skip to content

add CSE optimization tests for iterating over slice#150065

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
is57primenumber:add-slice-cse-test
Jan 25, 2026
Merged

add CSE optimization tests for iterating over slice#150065
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
is57primenumber:add-slice-cse-test

Conversation

@is57primenumber
Copy link
Contributor

@is57primenumber is57primenumber commented Dec 16, 2025 •
edited by rustbot
Loading

This PR is regression test for issue #119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nikic
nikic reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a codegen-llvm test, not an assembly-llvm test.

View changes since this review

@is57primenumber
Copy link
Contributor Author

is57primenumber commented Dec 25, 2025

Thank you for the feedback! I've updated the test from assembly-llvm to codegen-llvm.

Mark-Simulacrum
Mark-Simulacrum requested changes Jan 2, 2026
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@is57primenumber
Copy link
Contributor Author

is57primenumber commented Jan 2, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 2, 2026
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 4, 2026

r=me with commits squashed

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@is57primenumber
Copy link
Contributor Author

is57primenumber commented Jan 4, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2026
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 24, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

📌 Commit 65c1722 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
@matthiaskrgr
Rollup merge of rust-lang#150065 - is57primenumber:add-slice-cse-test…
c4f94f4 
…, r=Mark-Simulacrum

add CSE optimization tests for iterating over slice

This PR is regression test for issue rust-lang#119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
@matthiaskrgr
Rollup merge of rust-lang#150065 - is57primenumber:add-slice-cse-test…
3732d31 
…, r=Mark-Simulacrum

add CSE optimization tests for iterating over slice

This PR is regression test for issue rust-lang#119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
@matthiaskrgr
Rollup merge of rust-lang#150065 - is57primenumber:add-slice-cse-test…
73e49a9 
…, r=Mark-Simulacrum

add CSE optimization tests for iterating over slice

This PR is regression test for issue rust-lang#119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151617 - matthiaskrgr:rollup-5WPcrqe, r=matthiaskrgr
bf28e9e 
Rollup of 8 pull requests

Successful merges:

 - #145393 (Add codegen test for removing trailing zeroes from `NonZero`)
 - #149869 (std: avoid tearing `dbg!` prints)
 - #150065 (add CSE optimization tests for iterating over slice)
 - #150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7)
 - #151244 (Refine dummy_span.rs test)
 - #151505 (Various refactors to the proc_macro bridge)
 - #151560 (relnotes: fix 1.93's `as_mut_array` methods)
 - #151577 (Rename `DepKindStruct` to `DepKindVTable`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150065 - is57primenumber:add-slice-cse-test…
3ab8246 
…, r=Mark-Simulacrum

add CSE optimization tests for iterating over slice

This PR is regression test for issue rust-lang#119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 25, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151627 - JonathanBrouwer:rollup-txabfpM, r=JonathanBro…
69acb85 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #145393 (Add codegen test for removing trailing zeroes from `NonZero`)
 - #148764 (ptr_aligment_type: add more APIs)
 - #149869 (std: avoid tearing `dbg!` prints)
 - #150065 (add CSE optimization tests for iterating over slice)
 - #150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7)
 - #151505 (Various refactors to the proc_macro bridge)
 - #151560 (relnotes: fix 1.93's `as_mut_array` methods)
 - #151611 (Improve is_ascii performance on x86_64 with explicit SSE2 intrinsics)
 - #151317 (x86 soft-float feature: mark it as forbidden rather than unstable)
 - #151577 (Rename `DepKindStruct` to `DepKindVTable`)
 - #151620 (Fix 'the the' typo in library/core/src/array/iter.rs)
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 25, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151634 - matthiaskrgr:rollup-cE0JR24, r=matthiaskrgr
4d38622 
Rollup of 10 pull requests

Successful merges:

 - #145393 (Add codegen test for removing trailing zeroes from `NonZero`)
 - #148764 (ptr_aligment_type: add more APIs)
 - #149869 (std: avoid tearing `dbg!` prints)
 - #150065 (add CSE optimization tests for iterating over slice)
 - #150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7)
 - #151505 (Various refactors to the proc_macro bridge)
 - #151560 (relnotes: fix 1.93's `as_mut_array` methods)
 - #151317 (x86 soft-float feature: mark it as forbidden rather than unstable)
 - #151577 (Rename `DepKindStruct` to `DepKindVTable`)
 - #151620 (Fix 'the the' typo in library/core/src/array/iter.rs)
@rust-bors rust-bors bot merged commit 9dffb21 into rust-lang:main Jan 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 25, 2026
rust-timer added a commit that referenced this pull request Jan 25, 2026
@rust-timer
Unrolled build for #150065
cf4dd00 
Rollup merge of #150065 - is57primenumber:add-slice-cse-test, r=Mark-Simulacrum

add CSE optimization tests for iterating over slice

This PR is regression test for issue #119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151634 - matthiaskrgr:rollup-cE0JR24, r=matthiaskrgr
9857e08 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145393 (Add codegen test for removing trailing zeroes from `NonZero`)
 - rust-lang/rust#148764 (ptr_aligment_type: add more APIs)
 - rust-lang/rust#149869 (std: avoid tearing `dbg!` prints)
 - rust-lang/rust#150065 (add CSE optimization tests for iterating over slice)
 - rust-lang/rust#150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7)
 - rust-lang/rust#151505 (Various refactors to the proc_macro bridge)
 - rust-lang/rust#151560 (relnotes: fix 1.93's `as_mut_array` methods)
 - rust-lang/rust#151317 (x86 soft-float feature: mark it as forbidden rather than unstable)
 - rust-lang/rust#151577 (Rename `DepKindStruct` to `DepKindVTable`)
 - rust-lang/rust#151620 (Fix 'the the' typo in library/core/src/array/iter.rs)
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151634 - matthiaskrgr:rollup-cE0JR24, r=matthiaskrgr
6506ca5 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145393 (Add codegen test for removing trailing zeroes from `NonZero`)
 - rust-lang/rust#148764 (ptr_aligment_type: add more APIs)
 - rust-lang/rust#149869 (std: avoid tearing `dbg!` prints)
 - rust-lang/rust#150065 (add CSE optimization tests for iterating over slice)
 - rust-lang/rust#150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7)
 - rust-lang/rust#151505 (Various refactors to the proc_macro bridge)
 - rust-lang/rust#151560 (relnotes: fix 1.93's `as_mut_array` methods)
 - rust-lang/rust#151317 (x86 soft-float feature: mark it as forbidden rather than unstable)
 - rust-lang/rust#151577 (Rename `DepKindStruct` to `DepKindVTable`)
 - rust-lang/rust#151620 (Fix 'the the' typo in library/core/src/array/iter.rs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum requested changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@is57primenumber @rustbot @Mark-Simulacrum @nikic