Skip to content

Conversation

@reddevilmidzy
Copy link
Contributor

Note

Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

part of #133895

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@fee1-dead
Copy link
Member

Apologies for the late review. r=me after squash.

@bors rollup delegate+

@bors
Copy link
Collaborator

bors commented Dec 7, 2025

✌️ @reddevilmidzy, you can now approve this pull request!

If @fee1-dead told you to "r=me" after making some further change, please make that change, then do @bors r=@fee1-dead

@fee1-dead fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2025
merged tests/ui/issues/issue-2951.rs with
tests/ui/type/type-parameter-names.rs

Merged
tests/ui/for-loop-while/break-continue-in-loop-while-contiditoin-1.rs
with
tests/ui/for-loop-while/break-continue-in-loop-while-contiditoin-2.rs

Removed tests/ui/issues/issue-2383.rs
duplicated of library\alloc\src\collections\vec_deque\tests.rs

Removed tests/ui/issues/issue-20714.rs
duplicated of tests/ui/empty/empty-struct-unit-expr.rs

Added comment to tests/ui/match/match-option-result-mismatch.rs, tests/ui/numeric/ref-int.rs,
tests/ui/box/self-assignment.rs
@reddevilmidzy
Copy link
Contributor Author

No problem, thanks for the review :)

@bors r=@fee1-dead

@bors
Copy link
Collaborator

bors commented Dec 7, 2025

📌 Commit 79893a0 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2025
bors added a commit that referenced this pull request Dec 7, 2025
Rollup of 4 pull requests

Successful merges:

 - #147136 (Add warn-by-default lint for visibility on `const _` declarations)
 - #149498 (Tidying up `tests/ui/issues` tests [1/N])
 - #149721 (rustc book: fix `*-pc-windows-msvc` link label in sidebar)
 - #149724 (Fix off-by-one staging output when testing the library)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1f458c6 into rust-lang:main Dec 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 7, 2025
rust-timer added a commit that referenced this pull request Dec 7, 2025
Rollup merge of #149498 - reddevilmidzy:t8, r=fee1-dead

Tidying up `tests/ui/issues` tests [1/N]

> [!NOTE]
> Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

part of #133895
@reddevilmidzy reddevilmidzy deleted the t8 branch December 7, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants