-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Formally deprecate numeric consts modules #149249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @tgross35 |
This comment has been minimized.
This comment has been minimized.
|
I'm unclear about the order of operations when it comes to updating compiler-builtins (which only requires a single-line change). I'll submit a PR there to make the change, but what needs to be done on the rust-lang/rust side? |
This comment has been minimized.
This comment has been minimized.
|
Actually, now I'm even more confused, because I can't actually find the equivalent line in the upstream compiler-builtins. |
d5bf725 to
4beceab
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4beceab to
96f75b8
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
|
@rust-lang/libs-api |
96f75b8 to
6e65dd8
Compare
This comment has been minimized.
This comment has been minimized.
6e65dd8 to
026d21a
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
#146882 is also open, which does the deprecation but not the rest of the updates. I'll try to do a compiler-builtins sync soon. |
| #![deny(unsafe_op_in_unsafe_fn)] | ||
| #![deny(fuzzy_provenance_casts)] | ||
| #![warn(deprecated_in_future)] | ||
| #![warn(deprecated)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure: seems like we wouldn't want this? Is it just temporary while figuring out other things?
Long-overdue successor to #80958
Closes #68490