Skip to content

Conversation

@Muscraft
Copy link
Member

annotate-snippets simd feature enables the use of memchr when searching for char/str. This should hopefully improve performance when annotate-snippets is passed large source.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nnethercote
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 21, 2025
feat: Enable annotate-snippets' simd feature
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 21, 2025
@rust-bors
Copy link

rust-bors bot commented Nov 21, 2025

☀️ Try build successful (CI)
Build commit: 142ba45 (142ba4503a644fec1a5d10c42c45ca04805b4246, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (142ba45): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.3%, -0.1%] 5
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) -0.2% [-0.3%, -0.1%] 5

Max RSS (memory usage)

Results (primary 5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.8% [5.8%, 5.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 5.8% [5.8%, 5.8%] 1

Cycles

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-2.0%, 2.0%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.456s -> 474.214s (0.16%)
Artifact size: 388.90 MiB -> 388.90 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 21, 2025
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2025

📌 Commit 60427ac has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
…=davidtwco

feat: Enable annotate-snippets' simd feature

`annotate-snippets` `simd` feature enables the use of `memchr` when searching for `char`/`str`. This should hopefully improve performance when [`annotate-snippets` is passed large `source`](rust-lang#148188 (comment)).
bors added a commit that referenced this pull request Nov 22, 2025
Rollup of 9 pull requests

Successful merges:

 - #148407 (Warn against calls which mutate an interior mutable `const`-item)
 - #149065 (Address annotate-snippets test differences)
 - #149072 (Fix the issue of unused assignment from MIR liveness checking)
 - #149077 (feat: Enable annotate-snippets' simd feature)
 - #149168 (Fix ICE when collecting opaques from trait method declarations)
 - #149180 (Couple of refactors to SharedEmitter)
 - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
 - #149194 (Move safe computation out of unsafe block)
 - #149204 (Fix typo in HashMap performance comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d48305f into rust-lang:main Nov 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 22, 2025
rust-timer added a commit that referenced this pull request Nov 22, 2025
Rollup merge of #149077 - Muscraft:annotate-snippets-simd, r=davidtwco

feat: Enable annotate-snippets' simd feature

`annotate-snippets` `simd` feature enables the use of `memchr` when searching for `char`/`str`. This should hopefully improve performance when [`annotate-snippets` is passed large `source`](#148188 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants