flush_delayed: add note about stashed diagnostics #149020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
Turns out |
nnethercote
approved these changes
Nov 18, 2025
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup of 4 pull requests Successful merges: - #148970 (std: sys: fs: uefi: Implement stat) - #149020 (flush_delayed: add note about stashed diagnostics) - #149026 (Add test for href of reexported enum variant) - #149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup merge of #149020 - RalfJung:flush_delayed, r=nnethercote flush_delayed: add note about stashed diagnostics r? `@nnethercote` Is `emit_stashed_diagnostics` the right advice to give? The other option seems to be to call `finish_diagnostics`. That's what I ended up doing (for now) in rust-lang/miri#4702 because it best matches what happens during normal compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nnethercote
Is
emit_stashed_diagnosticsthe right advice to give? The other option seems to be to callfinish_diagnostics. That's what I ended up doing (for now) in rust-lang/miri#4702 because it best matches what happens during normal compilation.