-
Notifications
You must be signed in to change notification settings - Fork 14k
stabilize duration_from_nanos_u128 #148587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @rust-lang/wg-const-eval The Miri subtree was changed cc @rust-lang/miri |
|
rustbot has assigned @Mark-Simulacrum. Use |
|
r=me (unless you want to wait for Oli's response) r? @oli-obk |
|
|
|
@bors r=Mark-Simulacrum,oli-obk |
… r=Mark-Simulacrum,oli-obk stabilize duration_from_nanos_u128 libs-api FCP passed in rust-lang#139201. Closes rust-lang#139201. `@oli-obk` would you prefer if we did a const-hack to avoid allowing `const_trait_impl` here?
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d682af8 (parent) -> af5c5b7 (this PR) Test differencesShow 143 test diffs143 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard af5c5b74c8f2c0b1dfd9a201453bf2df538e93e0 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (af5c5b7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.838s -> 475.694s (0.60%) |
libs-api FCP passed in #139201.
Closes #139201.
@oli-obk would you prefer if we did a const-hack to avoid allowing
const_trait_implhere?