Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type #148491

estebank · 2025-11-04T18:13:07Z

Point at return type of async fns instead of their def Span.

Correctly provide suggestions when encountering async fn with a dyn Trait return type.

Correctly address type Alias = dyn Trait when fn foo() -> Alias { .. }.

rustbot · 2025-11-04T18:13:12Z

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-11-05T18:13:16Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

bors · 2025-11-11T13:38:33Z

☔ The latest upstream changes (presumably #148817) made this pull request unmergeable. Please resolve the merge conflicts.

jackh726 · 2025-11-25T06:38:18Z

r=me after rebase

estebank · 2025-12-08T23:13:16Z

@bors r=jackh726

bors · 2025-12-08T23:13:19Z

📌 Commit fa40a06 has been approved by jackh726

It is now in the queue for this repository.

Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type Point at return type of `async fn`s instead of their def `Span`. Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type. Correctly address `type Alias = dyn Trait` when `fn foo() -> Alias { .. }`. Fix rust-lang#147894.

Rollup of 12 pull requests Successful merges: - #147572 (std: Use more `unix.rs` code on WASI targets) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation) - #149652 (Add release notes for 1.92.0) - #149720 (rustdoc book: mention inner doc attribute) - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE) - #149754 (Retire `opt_str2` from compiletest cli parsing) - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings) - #149763 (Add inline attribute to generated delegation function if needed) - #149772 (test: Add a test for 146133) - #149779 (Fix typo "an" → "and") - #149782 (Remove `[no-mentions]` handler in the triagebot config) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-12-09T06:20:53Z

☔ The latest upstream changes (presumably #149426) made this pull request unmergeable. Please resolve the merge conflicts.

Rollup of 11 pull requests Successful merges: - #147585 (Suppress the error for private fields with non_exhaustive attribute) - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation) - #149652 (Add release notes for 1.92.0) - #149720 (rustdoc book: mention inner doc attribute) - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE) - #149754 (Retire `opt_str2` from compiletest cli parsing) - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings) - #149763 (Add inline attribute to generated delegation function if needed) - #149772 (test: Add a test for 146133) - #149779 (Fix typo "an" → "and") - #149782 (Remove `[no-mentions]` handler in the triagebot config) Failed merges: - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) r? `@ghost` `@rustbot` modify labels: rollup

…uggestion

``` error[E0277]: the size for values of type `(dyn Debug + 'static)` cannot be known at compilation time --> $DIR/dyn-trait-type-alias-return-type.rs:4:11 | LL | fn f() -> T { loop {} } | ^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `(dyn Debug + 'static)` note: this type alias is unsized --> $DIR/dyn-trait-type-alias-return-type.rs:1:1 | LL | type T = dyn core::fmt::Debug; | ^^^^^^ = note: the return type of a function must have a statically known size ```

rustbot · 2025-12-09T16:46:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

estebank · 2025-12-09T16:46:56Z

@bors r=jackh726

bors · 2025-12-09T16:46:59Z

📌 Commit f7eaaf7 has been approved by jackh726

It is now in the queue for this repository.

Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type Point at return type of `async fn`s instead of their def `Span`. Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type. Correctly address `type Alias = dyn Trait` when `fn foo() -> Alias { .. }`. Fix rust-lang#147894.

Rollup of 6 pull requests Successful merges: - #147602 (Deduplicate higher-ranked lifetime capture errors in impl Trait) - #147725 (Remove -Zoom=panic) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #148717 (Point at span within local macros even when error happens in nested external macro) - #149458 (Run clippy on cg_gcc in CI) - #149816 (Make typo in field and name suggestions verbose) r? `@ghost` `@rustbot` modify labels: rollup

Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type Point at return type of `async fn`s instead of their def `Span`. Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type. Correctly address `type Alias = dyn Trait` when `fn foo() -> Alias { .. }`. Fix rust-lang#147894.

Rollup of 12 pull requests Successful merges: - #147602 (Deduplicate higher-ranked lifetime capture errors in impl Trait) - #147725 (Remove -Zoom=panic) - #148294 (callconv: fix mips64 aggregate argument passing for C FFI) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149417 (tidy: Detect outdated workspaces in workspace list) - #149458 (Run clippy on cg_gcc in CI) - #149679 (Restrict spe_acc to PowerPC SPE targets) - #149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - #149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - #149816 (Make typo in field and name suggestions verbose) - #149824 (Add a regression test for issue 145748) - #149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #147725 (Remove -Zoom=panic) - #148294 (callconv: fix mips64 aggregate argument passing for C FFI) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149458 (Run clippy on cg_gcc in CI) - #149679 (Restrict spe_acc to PowerPC SPE targets) - #149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - #149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - #149816 (Make typo in field and name suggestions verbose) - #149824 (Add a regression test for issue 145748) - #149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148491 - estebank:issue-147894, r=jackh726 Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type Point at return type of `async fn`s instead of their def `Span`. Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type. Correctly address `type Alias = dyn Trait` when `fn foo() -> Alias { .. }`. Fix #147894.

Rollup of 10 pull requests Successful merges: - rust-lang/rust#147725 (Remove -Zoom=panic) - rust-lang/rust#148294 (callconv: fix mips64 aggregate argument passing for C FFI) - rust-lang/rust#148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - rust-lang/rust#149458 (Run clippy on cg_gcc in CI) - rust-lang/rust#149679 (Restrict spe_acc to PowerPC SPE targets) - rust-lang/rust#149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - rust-lang/rust#149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - rust-lang/rust#149816 (Make typo in field and name suggestions verbose) - rust-lang/rust#149824 (Add a regression test for issue 145748) - rust-lang/rust#149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jackh726 Nov 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2025

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-147894 branch from 588dedd to 8eb24d0 Compare November 4, 2025 19:44

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-147894 branch from 8eb24d0 to 44623a5 Compare November 4, 2025 22:13

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-147894 branch from 44623a5 to f9ccc9a Compare November 5, 2025 18:13

rustbot added the T-clippy Relevant to the Clippy team. label Nov 5, 2025

This comment was marked as resolved.

Sign in to view

estebank force-pushed the issue-147894 branch from e09db53 to 93dd2fe Compare November 5, 2025 19:38

jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025

estebank force-pushed the issue-147894 branch from 2af6b53 to fa40a06 Compare December 8, 2025 20:57

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2025

Zalathar mentioned this pull request Dec 9, 2025

Rollup of 12 pull requests #149796

Closed

matthiaskrgr mentioned this pull request Dec 9, 2025

Rollup of 11 pull requests #149798

Merged

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 9, 2025

estebank added 8 commits December 9, 2025 16:46

Use return type Span on async fns instead of whole fn def Span

20fabb4

Add test for dyn Trait in async fn return type

76f02cf

Account for async fn with dyn Trait return type in impl Trait s…

7868d20

…uggestion

Add test for type Alias = dyn Trait in return type

fabf574

Point at async fn return type instead of body in E0746

e2168b1

Provide boxing suggestion for type Alias = dyn Trait return type

8c63852

Account for async fn in traits and impls

f7eaaf7

estebank force-pushed the issue-147894 branch from fa40a06 to f7eaaf7 Compare December 9, 2025 16:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2025

matthiaskrgr mentioned this pull request Dec 9, 2025

Rollup of 6 pull requests #149820

Closed

Zalathar mentioned this pull request Dec 10, 2025

Rollup of 13 pull requests #149828

Closed

Zalathar mentioned this pull request Dec 10, 2025

Rollup of 12 pull requests #149830

Closed

matthiaskrgr mentioned this pull request Dec 10, 2025

Rollup of 10 pull requests #149836

Merged

bors merged commit 8a4312a into rust-lang:main Dec 10, 2025
11 checks passed

rustbot added this to the 1.94.0 milestone Dec 10, 2025

github-actions bot mentioned this pull request Dec 12, 2025

Toolchain upgrade to nightly-2025-12-11 flux-rs/flux#1345

Draft

Uh oh!

Correctly provide suggestions when encountering async fn with a dyn Trait return type #148491

Correctly provide suggestions when encountering async fn with a dyn Trait return type #148491

Uh oh!

Conversation

estebank commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 5, 2025

Uh oh!

This comment was marked as resolved.

bors commented Nov 11, 2025

Uh oh!

jackh726 commented Nov 25, 2025

Uh oh!

This comment has been minimized.

estebank commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

rustbot commented Dec 9, 2025

Uh oh!

estebank commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type #148491

Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type #148491

estebank commented Nov 4, 2025 •

edited

Loading