Skip to content

Conversation

@aDotInTheVoid
Copy link
Member

Spun out of #142642

In the future, I want the rustdoc-json test suite to invoke rustdoc twice, once with --output-format=json, and once with the (not yet implemented) --output-format=postcard flag.

Doing that requires being able to explicitly tell the .document() function which format to use, rather then implicitly using json in the rustdoc-json suite, and HTML in all others.

r? @jieyouxu

CC @jalil-salame

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 22, 2025
@aDotInTheVoid aDotInTheVoid added the A-rustdoc-json Area: Rustdoc JSON backend label Oct 22, 2025
Spun out of https://www.github.com/rust-lang/rust/pull/142642

In the future, I want the rustdoc-json test suite to invoke rustdoc
twice, once with `--output-format=json`, and once with the (not yet
implemented) `--output-format=postcard` flag.

Doing that requires being able to explicitly tell the `.document()`
function which format to use, rather then implicitly using json in the
rustdoc-json suite, and HTML in all others.
@rust-cloud-vms rust-cloud-vms bot force-pushed the rustdoc-postcard-compiletest-groundwork branch from 478d894 to 616fff7 Compare October 24, 2025 18:32
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

📌 Commit 616fff7 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 616fff7 with merge 2888098...

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 2888098 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2025
@bors bors merged commit 2888098 into rust-lang:master Oct 26, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 26, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 58b4453 (parent) -> 2888098 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2888098522be731065efe51f85eaba8b49fee1a5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3026.7s -> 3604.6s (19.1%)
  2. dist-x86_64-apple: 6059.1s -> 7068.0s (16.7%)
  3. pr-check-1: 1437.9s -> 1294.5s (-10.0%)
  4. dist-aarch64-msvc: 5925.4s -> 5386.0s (-9.1%)
  5. aarch64-apple: 7068.4s -> 7673.6s (8.6%)
  6. x86_64-msvc-2: 6472.4s -> 6948.7s (7.4%)
  7. test-various: 6021.3s -> 6462.3s (7.3%)
  8. i686-gnu-1: 7435.9s -> 6894.4s (-7.3%)
  9. dist-powerpc64le-linux-musl: 4959.2s -> 5304.9s (7.0%)
  10. dist-sparcv9-solaris: 4900.7s -> 5241.2s (6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2888098): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 0.6%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) 0.6% [-1.2%, 2.4%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.903s -> 476.488s (0.12%)
Artifact size: 390.47 MiB -> 390.47 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants