-
Couldn't load subscription status.
- Fork 13.9k
compiletest: pass rustdoc mode as param, rather than implicitly #148003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiletest: pass rustdoc mode as param, rather than implicitly #148003
Conversation
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Spun out of https://www.github.com/rust-lang/rust/pull/142642 In the future, I want the rustdoc-json test suite to invoke rustdoc twice, once with `--output-format=json`, and once with the (not yet implemented) `--output-format=postcard` flag. Doing that requires being able to explicitly tell the `.document()` function which format to use, rather then implicitly using json in the rustdoc-json suite, and HTML in all others.
478d894 to
616fff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 58b4453 (parent) -> 2888098 (this PR) Test differencesShow 3 test diffs3 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 2888098522be731065efe51f85eaba8b49fee1a5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (2888098): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 0.6%, secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.903s -> 476.488s (0.12%) |
Spun out of #142642
In the future, I want the rustdoc-json test suite to invoke rustdoc twice, once with
--output-format=json, and once with the (not yet implemented)--output-format=postcardflag.Doing that requires being able to explicitly tell the
.document()function which format to use, rather then implicitly using json in the rustdoc-json suite, and HTML in all others.r? @jieyouxu
CC @jalil-salame