-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
compiletest: Include a file path in DirectiveLine
#147879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+75
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a `DirectiveLine`.
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
jieyouxu
approved these changes
Oct 19, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me once PR CI is green
Member
Author
|
@bors r=jieyouxu |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 19, 2025
Rollup of 3 pull requests Successful merges: - #147870 (`std::thread::available_parallelism()` vxworks libc symbol usage.) - #147879 (compiletest: Include a file path in `DirectiveLine`) - #147880 (Add a triagebot reminder to update rustc-dev-guide docs when modifying compiletest directives) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 20, 2025
Rollup merge of #147879 - Zalathar:directive, r=jieyouxu compiletest: Include a file path in `DirectiveLine` This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a `DirectiveLine`. r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a
DirectiveLine.r? jieyouxu