Synchronize the start of threads in poison_timeout_nanoseconds test #147871
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
That would require the spawning thread to not be scheduled for 2 seconds, which seems unlikely. I've opened #147910 as an alternative. |
|
Hm, fair. I do think it's technically possible but indeed unlikely. I'll close this in favour of yours. |
rustbot
removed
the
S-waiting-on-review
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 20, 2025
… r=ChrisDenton handle spurious returns of `wait_timeout` in test Fixes rust-lang#147885 Closes rust-lang#147871 `wait_timeout` is allowed to spuriously return, hence the `timeout_nanoseconds` must not assume that the wakeup resulted from a `notify_all()`.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Oct 22, 2025
handle spurious returns of `wait_timeout` in test Fixes rust-lang/rust#147885 Closes rust-lang/rust#147871 `wait_timeout` is allowed to spuriously return, hence the `timeout_nanoseconds` must not assume that the wakeup resulted from a `notify_all()`.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 27, 2025
handle spurious returns of `wait_timeout` in test Fixes rust-lang/rust#147885 Closes rust-lang/rust#147871 `wait_timeout` is allowed to spuriously return, hence the `timeout_nanoseconds` must not assume that the wakeup resulted from a `notify_all()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the sporadic Windows test failures may be due to thread scheduling under high contention so workaround this by synchronising the two threads at the start.