Liveness: Cache the set of string constants for suggestions.

[cjgillot]

Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.

[cjgillot]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)

[rust-timer]

Finished benchmarking commit (adc508b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.4%]	4
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-0.8%	[-1.3%, -0.4%]	4

Max RSS (memory usage)

Results (primary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[2.5%, 6.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.4%, -2.1%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[cjgillot]

r? estebank

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[cjgillot]

r? compiler

[estebank]

@bors r+

[bors]

📌 Commit 727da8c has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit 727da8c with merge 9606412...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 9606412 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. tidy: 296.8s -> 173.3s (-41.6%)
2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (9606412): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.4%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-1.4%, -0.5%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.7%	[-5.7%, -5.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)